Bug 83803 - Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage
Summary: Make AccessibilityObject::size non-virtual and fix platform accessibility cod...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-12 12:06 PDT by Levi Weintraub
Modified: 2012-04-12 13:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.65 KB, patch)
2012-04-12 12:11 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-12 12:06:08 PDT 
AccessibilityObject has a virtual size() method, but all overloads do the same thing. Removing the virtual modifier and all overloaded copies of the function, adding a pixelSnappedSize method, and using it for platform code.
Comment 1 Levi Weintraub 2012-04-12 12:11:37 PDT 
Created attachment 136951 [details]
Patch
Comment 2 Levi Weintraub 2012-04-12 13:08:51 PDT 
Thanks Eric!
Comment 3 WebKit Review Bot 2012-04-12 13:57:04 PDT 
Comment on attachment 136951 [details]
Patch

Clearing flags on attachment: 136951

Committed r114031: <http://trac.webkit.org/changeset/114031>
Comment 4 WebKit Review Bot 2012-04-12 13:57:09 PDT 
All reviewed patches have been landed.  Closing bug.