Bug 83798 - [Chromium] Fix some conditional compilation logic in Platform
Summary: [Chromium] Fix some conditional compilation logic in Platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Peters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 11:32 PDT by Gavin Peters
Modified: 2012-04-25 07:41 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.46 KB, patch)
2012-04-12 11:33 PDT, Gavin Peters
no flags Details | Formatted Diff | Diff
fix WebFrameTests too (4.70 KB, patch)
2012-04-23 08:31 PDT, Gavin Peters
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2012-04-12 11:32:42 PDT
Fix some conditional compilation logic in Platform
Comment 1 Gavin Peters 2012-04-12 11:33:03 PDT
Created attachment 136940 [details]
Patch
Comment 2 Gavin Peters 2012-04-12 11:34:54 PDT
Adam, WDYT?
Comment 3 WebKit Review Bot 2012-04-12 11:35:58 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2012-04-12 12:08:03 PDT
Comment on attachment 136940 [details]
Patch

Attachment 136940 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12391562
Comment 5 Gavin Peters 2012-04-12 12:16:29 PDT
That failure is very sadmaking.  I'll rework the patch once I have a branch at head, and fix the environment of that test.
Comment 6 Adam Barth 2012-04-12 13:13:30 PDT
> Adam, WDYT?

Dunno.  fishd should probably review this patch.  I'm still a noob at reviewing API changes.
Comment 7 Gavin Peters 2012-04-23 08:31:08 PDT
Created attachment 138354 [details]
fix WebFrameTests too
Comment 8 WebKit Review Bot 2012-04-25 07:41:43 PDT
Comment on attachment 138354 [details]
fix WebFrameTests too

Clearing flags on attachment: 138354

Committed r115206: <http://trac.webkit.org/changeset/115206>
Comment 9 WebKit Review Bot 2012-04-25 07:41:50 PDT
All reviewed patches have been landed.  Closing bug.