WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83793
convolution-mono-mono test passes now
https://bugs.webkit.org/show_bug.cgi?id=83793
Summary
convolution-mono-mono test passes now
Raymond Toy
Reported
2012-04-12 10:44:29 PDT
The convolution-mono-mono test is marked as expected to crash on debug builds. This isn't true anymore and should be deleted.
Attachments
Patch
(1.40 KB, patch)
2012-04-12 10:48 PDT
,
Raymond Toy
no flags
Details
Formatted Diff
Diff
Patch
(1.34 KB, patch)
2012-04-13 11:33 PDT
,
Raymond Toy
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Raymond Toy
Comment 1
2012-04-12 10:48:03 PDT
Created
attachment 136929
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-04-12 10:58:06 PDT
Comment on
attachment 136929
[details]
Patch LGTM.
Eric Seidel (no email)
Comment 3
2012-04-12 11:08:31 PDT
Comment on
attachment 136929
[details]
Patch The patch doesn't seem to apply, so you'll likely need to upload a new one.
WebKit Review Bot
Comment 4
2012-04-12 11:10:42 PDT
Comment on
attachment 136929
[details]
Patch Rejecting
attachment 136929
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3515. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output:
http://queues.webkit.org/results/12390558
Raymond Toy
Comment 5
2012-04-13 11:33:13 PDT
Created
attachment 137113
[details]
Patch
Eric Seidel (no email)
Comment 6
2012-04-13 14:20:36 PDT
Comment on
attachment 137113
[details]
Patch LGTM.
Raymond Toy
Comment 7
2012-04-13 14:42:49 PDT
***
Bug 81778
has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 8
2012-04-13 18:27:28 PDT
Comment on
attachment 137113
[details]
Patch Clearing flags on attachment: 137113 Committed
r114194
: <
http://trac.webkit.org/changeset/114194
>
WebKit Review Bot
Comment 9
2012-04-13 18:27:32 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug