Bug 83778 - [chromium] Fix threaded compositor HUD crash
Summary: [chromium] Fix threaded compositor HUD crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sami Kyostila
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 06:39 PDT by Sami Kyostila
Modified: 2012-04-12 10:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2012-04-12 06:43 PDT, Sami Kyostila
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Kyostila 2012-04-12 06:39:49 PDT
[chromium] Fix threaded compositor HUD crash
Comment 1 Sami Kyostila 2012-04-12 06:43:33 PDT
Created attachment 136893 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-12 10:17:03 PDT
Comment on attachment 136893 [details]
Patch

Clearing flags on attachment: 136893

Committed r114000: <http://trac.webkit.org/changeset/114000>
Comment 3 WebKit Review Bot 2012-04-12 10:17:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Alex Nicolaou 2012-04-12 10:27:23 PDT
Sorry for introducing this bug - should have seen it when I did the merge with the other refactoring - but also, it would be simpler and just as good to just hardcode a 50 instead of 40 and ignore the font size in all cases.
Comment 5 Sami Kyostila 2012-04-12 10:38:23 PDT
Right. I wasn't sure why the font size was being included in the height, since here the fps counter is drawn to the left of the graph instead of on top of it. Feel free to bump this to 50 if that is closer to the intended effect.
Comment 6 Shawn Singh 2012-04-12 10:41:21 PDT
FYI I'm about to clobber the font rendering code anyway, so that the HUD can work in multithreaded mode =)

I had a nice layout that I think you'll like, otherwise feel free to adjust it afterwards