Bug 83776 – [EFL] EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

EFL's LayoutTestController needs evaluateScriptInIsolatedWorld implementation in order to unskip:
http/tests/security/isolatedWorld

storage/open-database-creation-callback-isolated-world.html
storage/statement-error-callback-isolated-world.html
storage/statement-success-callback-isolated-world.html
storage/transaction-callback-isolated-world.html
storage/transaction-error-callback-isolated-world.html
storage/transaction-success-callback-isolated-world.html

[Mikhail Pozdnyakov]

Created attachment 138534 [details]
EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

This patch just provides testcases unskipped.
Mac and Win ports export 'stringByEvaluatingJavaScriptInScriptWorld' api, advisability of such api for EFL port 
should be discussed.

[Mikhail Pozdnyakov]

Created attachment 138798 [details]
EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

Rebased version.

[Rafael Antognolli]

(In reply to comment #2)
> Created an attachment (id=138798) [details]
> EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation
> 
> Rebased version.

Hello Mikhail,

The patch looks good to me, but my knowledge on this area is very small. I would like you to ask for guys who worked on the DRT support to review it, please.

Regards,
Rafael

[Mikhail Pozdnyakov]

Created attachment 138868 [details]
EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

Fixed WTF::String creation (see https://bugs.webkit.org/show_bug.cgi?id=84718#c7)

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138868 [details]
EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

It looks like most of the patch is boilerplate and JSC plumbing which I'm not familiar with. Assuming that's right (ie. it's code used by other ports), looks fine from the EFL side.

[Tor Arne Vestbø]

Comment on attachment 138868 [details]
EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

lgtm

[WebKit Review Bot]

Comment on attachment 138868 [details]
EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

Rejecting attachment 138868 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Support/DumpRenderTreeSupportEfl.cpp.rej
patching file Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
Hunk #1 succeeded at 88 (offset 4 lines).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
Hunk #1 succeeded at 724 (offset 27 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Tor Arne V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12694683

[Gyuyoung Kim]

Comment on attachment 138868 [details]
EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation

Need to rebase.

[Mikhail Pozdnyakov]

Created attachment 142187 [details]
to be landed.

[WebKit Review Bot]

Comment on attachment 142187 [details]
to be landed.

Clearing flags on attachment: 142187

Committed r117255: <http://trac.webkit.org/changeset/117255>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.