Bug 83772 – [BlackBerry] Set referrer for plugin load if needed.

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit BlackBerry

[Charles Wei]

Set referrer for resources requested by plugin.

[Charles Wei]

Created attachment 136883 [details]
Patch

[Rob Buis]

Comment on attachment 136883 [details]
Patch

Looks ideal for a helper method :)

[Charles Wei]

(In reply to comment #2)
> (From update of attachment 136883 [details])
> Looks ideal for a helper method :)

Good suggestion. That makes less code.

[Charles Wei]

Created attachment 136891 [details]
Patch

[Early Warning System Bot]

Comment on attachment 136891 [details]
Patch

Attachment 136891 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12390428

[Philippe Normand]

Comment on attachment 136891 [details]
Patch

Attachment 136891 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12390426

[Build Bot]

Comment on attachment 136891 [details]
Patch

Attachment 136891 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12387728

[Charles Wei]

Comment on attachment 136891 [details]
Patch

typo in the patch, and revoke the review request.

[Charles Wei]

Created attachment 136902 [details]
Patch

[Philippe Normand]

Comment on attachment 136902 [details]
Patch

Attachment 136902 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12395263

[Early Warning System Bot]

Comment on attachment 136902 [details]
Patch

Attachment 136902 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12393383

[Build Bot]

Comment on attachment 136902 [details]
Patch

Attachment 136902 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12389542

[Antonio Gomes]

Comment on attachment 136902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136902&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, initial upstream of BlackBerry porting.

plePlease say what it fixes, and why others might not need this.

> Source/WebCore/plugins/PluginView.cpp:127
> +static void setReferrerIfNeeded(FrameLoaderRequest request, const Frame* parentFrame)
> +{
> +#if PLATFORM(BLACKBERRY)
> +    if (!SecurityPolicy::shouldHideReferrer(request.resourceRequest().url(), parentFrame->document()->baseURL()))
> +        request.resourceRequest().setHTTPReferrer(parentFrame->loader()->outgoingReferrer());
> +#endif
> +}

use param_unused in a #else block, please.