Bug 83772 - [BlackBerry] Set referrer for plugin load if needed.
Summary: [BlackBerry] Set referrer for plugin load if needed.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks: 83360
  Show dependency tree / graph
 
Reported: 2012-04-12 05:19 PDT by Charles Wei
Modified: 2014-01-28 08:15 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.65 KB, patch)
2012-04-12 05:24 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2012-04-12 06:30 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2012-04-12 07:09 PDT, Charles Wei 		tonikitoo: review-
pnormand: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-04-12 05:19:04 PDT 
Set referrer for resources requested by plugin.
Comment 1 Charles Wei 2012-04-12 05:24:59 PDT 
Created attachment 136883 [details]
Patch
Comment 2 Rob Buis 2012-04-12 05:27:10 PDT 
Comment on attachment 136883 [details]
Patch

Looks ideal for a helper method :)
Comment 3 Charles Wei 2012-04-12 05:46:05 PDT 
(In reply to comment #2)
> (From update of attachment 136883 [details])
> Looks ideal for a helper method :)

Good suggestion. That makes less code.
Comment 4 Charles Wei 2012-04-12 06:30:42 PDT 
Created attachment 136891 [details]
Patch
Comment 5 Early Warning System Bot 2012-04-12 06:43:08 PDT 
Comment on attachment 136891 [details]
Patch

Attachment 136891 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12390428
Comment 6 Philippe Normand 2012-04-12 06:46:15 PDT 
Comment on attachment 136891 [details]
Patch

Attachment 136891 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12390426
Comment 7 Build Bot 2012-04-12 06:46:59 PDT 
Comment on attachment 136891 [details]
Patch

Attachment 136891 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12387728
Comment 8 Charles Wei 2012-04-12 06:59:37 PDT 
Comment on attachment 136891 [details]
Patch

typo in the patch, and revoke the review request.
Comment 9 Charles Wei 2012-04-12 07:09:20 PDT 
Created attachment 136902 [details]
Patch
Comment 10 Philippe Normand 2012-04-12 07:13:24 PDT 
Comment on attachment 136902 [details]
Patch

Attachment 136902 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12395263
Comment 11 Early Warning System Bot 2012-04-12 07:14:10 PDT 
Comment on attachment 136902 [details]
Patch

Attachment 136902 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12393383
Comment 12 Build Bot 2012-04-12 07:34:58 PDT 
Comment on attachment 136902 [details]
Patch

Attachment 136902 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12389542
Comment 13 Antonio Gomes 2012-04-12 07:51:19 PDT 
Comment on attachment 136902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136902&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, initial upstream of BlackBerry porting.

plePlease say what it fixes, and why others might not need this.

> Source/WebCore/plugins/PluginView.cpp:127
> +static void setReferrerIfNeeded(FrameLoaderRequest request, const Frame* parentFrame)
> +{
> +#if PLATFORM(BLACKBERRY)
> +    if (!SecurityPolicy::shouldHideReferrer(request.resourceRequest().url(), parentFrame->document()->baseURL()))
> +        request.resourceRequest().setHTTPReferrer(parentFrame->loader()->outgoingReferrer());
> +#endif
> +}

use param_unused in a #else block, please.