Bug 83768 - [GTK] Migrate Skipped tests to test_expectations.txt
Summary: [GTK] Migrate Skipped tests to test_expectations.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 04:04 PDT by Philippe Normand
Modified: 2012-04-12 08:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (142.15 KB, patch)
2012-04-12 07:05 PDT, Philippe Normand
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-04-12 04:04:09 PDT
For tests without bug entry I'll use BUGWKGTK. The initial approach I used is to mark them FAIL but some also TIMEOUT, so I think we'll need an iterative process with the bots :)
Comment 1 Philippe Normand 2012-04-12 05:46:19 PDT
And I'll use the SKIP modifier as wisely as possible.
Comment 2 Philippe Normand 2012-04-12 07:05:26 PDT
Created attachment 136901 [details]
Patch
Comment 3 Philippe Normand 2012-04-12 07:09:10 PDT
If/when we land this we'll need to keep an eye on the bots. From what I could see locally with a 64-bit Debug build:


=> Results: 26212/29119 tests passed (90.0%)

=> Tests to be fixed (2907):
      3 crashes                  ( 0.1%)
      2 tests timed out          ( 0.1%)
     90 no expected results found ( 3.1%)
    685 text diff mismatch       (23.6%)
     42 image mismatch           ( 1.4%)
   2085 skipped                  (71.7%)


Expected to crash, but passed: (14)
Expected to timeout, but passed: (7)
Expected to fail, but passed: (161)
Regressions: Unexpected no expected results found : (90)
Comment 4 Martin Robinson 2012-04-12 07:57:18 PDT
Comment on attachment 136901 [details]
Patch

Do you think you can keep the text at the beginning explaining the different sections. It's useful because we are the only ones that organize our skipped list this way.
Comment 5 Philippe Normand 2012-04-12 08:01:37 PDT
(In reply to comment #4)
> (From update of attachment 136901 [details])
> Do you think you can keep the text at the beginning explaining the different sections. It's useful because we are the only ones that organize our skipped list this way.

Sure! I'll land this ASAP :) Thanks!
Comment 6 Philippe Normand 2012-04-12 08:14:02 PDT
Committed r113981: <http://trac.webkit.org/changeset/113981>