Bug 83768 – [GTK] Migrate Skipped tests to test_expectations.txt

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Philippe Normand]

For tests without bug entry I'll use BUGWKGTK. The initial approach I used is to mark them FAIL but some also TIMEOUT, so I think we'll need an iterative process with the bots :)

[Philippe Normand]

And I'll use the SKIP modifier as wisely as possible.

[Philippe Normand]

Created attachment 136901 [details]
Patch

[Philippe Normand]

If/when we land this we'll need to keep an eye on the bots. From what I could see locally with a 64-bit Debug build:


=> Results: 26212/29119 tests passed (90.0%)

=> Tests to be fixed (2907):
      3 crashes                  ( 0.1%)
      2 tests timed out          ( 0.1%)
     90 no expected results found ( 3.1%)
    685 text diff mismatch       (23.6%)
     42 image mismatch           ( 1.4%)
   2085 skipped                  (71.7%)


Expected to crash, but passed: (14)
Expected to timeout, but passed: (7)
Expected to fail, but passed: (161)
Regressions: Unexpected no expected results found : (90)

[Martin Robinson]

Comment on attachment 136901 [details]
Patch

Do you think you can keep the text at the beginning explaining the different sections. It's useful because we are the only ones that organize our skipped list this way.

[Philippe Normand]

(In reply to comment #4)
> (From update of attachment 136901 [details])
> Do you think you can keep the text at the beginning explaining the different sections. It's useful because we are the only ones that organize our skipped list this way.

Sure! I'll land this ASAP :) Thanks!

[Philippe Normand]

Committed r113981: <http://trac.webkit.org/changeset/113981>