RESOLVED FIXED 83753
[GTK] Enable WebKit2 by default in configure
https://bugs.webkit.org/show_bug.cgi?id=83753
Summary [GTK] Enable WebKit2 by default in configure
Carlos Garcia Campos
Reported 2012-04-12 00:54:19 PDT
It's currently enabled by default by webkit-build, but disabled in configure. We should enable it in configure so that unstable releases will build webkit2 by default.
Attachments
Patch (1005 bytes, patch)
2012-04-12 00:55 PDT, Carlos Garcia Campos
mrobinson: review+
Carlos Garcia Campos
Comment 1 2012-04-12 00:55:53 PDT
Martin Robinson
Comment 2 2012-04-12 08:11:53 PDT
Comment on attachment 136841 [details] Patch Exciting! We need to take care of the library versioning before the next release though.
Carlos Garcia Campos
Comment 3 2012-04-12 23:00:29 PDT
Gustavo Noronha (kov)
Comment 4 2012-04-16 08:24:50 PDT
Does this mean we want distributions to start shipping webkit2? I think it would be good to make sure we state it's still unstable API-wise, but I'll be happy to ship webkit2 packages in Debian =)
Martin Robinson
Comment 5 2012-04-16 08:26:59 PDT
(In reply to comment #4) > Does this mean we want distributions to start shipping webkit2? I think it would be good to make sure we state it's still unstable API-wise, but I'll be happy to ship webkit2 packages in Debian =) That's a good point. Perhaps we should wait to do this until the last moment. The versions of WebKit2 before the next stable release are not API stable.
Carlos Garcia Campos
Comment 6 2012-04-16 08:30:49 PDT
I think it's up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change.
Martin Robinson
Comment 7 2012-04-16 09:39:02 PDT
(In reply to comment #6) > I think it's up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change. We'll have to be pretty clear about this in release notes and elsewhere, becuase up to this point, we rarely break API even in unstable branches.
Carlos Garcia Campos
Comment 8 2012-04-16 11:11:36 PDT
(In reply to comment #7) > (In reply to comment #6) > > I think it's up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change. > > We'll have to be pretty clear about this in release notes and elsewhere, becuase up to this point, we rarely break API even in unstable branches. Ok, I thought it was clear that the backwards compatibility guarantee only affects stable releases.
Gustavo Noronha (kov)
Comment 9 2012-04-16 12:36:37 PDT
It might just be me worrying too much. I guess it is hint enough that it's only in unstable releases.
Note You need to log in before you can comment on or make changes to this bug.