Bug 83753 - [GTK] Enable WebKit2 by default in configure
Summary: [GTK] Enable WebKit2 by default in configure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-12 00:54 PDT by Carlos Garcia Campos
Modified: 2012-04-16 12:36 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1005 bytes, patch)
2012-04-12 00:55 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-04-12 00:54:19 PDT
It's currently enabled by default by webkit-build, but disabled in configure. We should enable it in configure so that unstable releases will build webkit2 by default.
Comment 1 Carlos Garcia Campos 2012-04-12 00:55:53 PDT
Created attachment 136841 [details]
Patch
Comment 2 Martin Robinson 2012-04-12 08:11:53 PDT
Comment on attachment 136841 [details]
Patch

Exciting! We need to take care of the library versioning before the next release though.
Comment 3 Carlos Garcia Campos 2012-04-12 23:00:29 PDT
Committed r114084: <http://trac.webkit.org/changeset/114084>
Comment 4 Gustavo Noronha (kov) 2012-04-16 08:24:50 PDT
Does this mean we want distributions to start shipping webkit2? I think it would be good to make sure we state it's still unstable API-wise, but I'll be happy to ship webkit2 packages in Debian =)
Comment 5 Martin Robinson 2012-04-16 08:26:59 PDT
(In reply to comment #4)
> Does this mean we want distributions to start shipping webkit2? I think it would be good to make sure we state it's still unstable API-wise, but I'll be happy to ship webkit2 packages in Debian =)

That's a good point. Perhaps we should wait to do this until the last moment. The versions of WebKit2 before the next stable release are not API stable.
Comment 6 Carlos Garcia Campos 2012-04-16 08:30:49 PDT
I think it's up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change.
Comment 7 Martin Robinson 2012-04-16 09:39:02 PDT
(In reply to comment #6)
> I think it's up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change.

We'll have to be pretty clear about this in release notes and elsewhere, becuase up to this point, we rarely break API even in unstable branches.
Comment 8 Carlos Garcia Campos 2012-04-16 11:11:36 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > I think it's up to distros to decide, we have only enabled webkit2 option in configure by default in current trunk, not in the stable branch. That means that unstable releases will build webkit2 by default, but like any other unstable release cycle, the API might change.
> 
> We'll have to be pretty clear about this in release notes and elsewhere, becuase up to this point, we rarely break API even in unstable branches.

Ok, I thought it was clear that the backwards compatibility guarantee only affects stable releases.
Comment 9 Gustavo Noronha (kov) 2012-04-16 12:36:37 PDT
It might just be me worrying too much. I guess it is hint enough that it's only in unstable releases.