Bug 83749 - Leak in WebSocketChannel with workers/worker-reload.html (part 2)
Summary: Leak in WebSocketChannel with workers/worker-reload.html (part 2)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 23:30 PDT by Yuta Kitamura
Modified: 2012-04-15 18:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.07 KB, patch)
2012-04-12 03:02 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2012-04-11 23:30:05 PDT 
Follow-up of bug 83345. See also http://code.google.com/p/chromium/issues/detail?id=122233

Even after a speculative fix at r113414, there are still some similar leaks reported. After some investigation I found:
- A silly mistake in Chromium's WebWorkerClientImpl, and
- Potential race condition that causes Peer objects to leak.
Comment 1 Yuta Kitamura 2012-04-12 03:02:49 PDT 
Created attachment 136863 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-15 18:43:56 PDT 
Comment on attachment 136863 [details]
Patch

Clearing flags on attachment: 136863

Committed r114215: <http://trac.webkit.org/changeset/114215>
Comment 3 WebKit Review Bot 2012-04-15 18:44:00 PDT 
All reviewed patches have been landed.  Closing bug.