WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83733
[chromium] Remove unused compositeToTexture / compositeOffscreen setting
https://bugs.webkit.org/show_bug.cgi?id=83733
Summary
[chromium] Remove unused compositeToTexture / compositeOffscreen setting
James Robinson
Reported
2012-04-11 17:17:36 PDT
[chromium] Remove unused compositeToTexture / compositeOffscreen setting
Attachments
Patch
(20.88 KB, patch)
2012-04-11 17:19 PDT
,
James Robinson
enne
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-04-11 17:19:17 PDT
Created
attachment 136794
[details]
Patch
James Robinson
Comment 2
2012-04-11 17:20:32 PDT
This depends on
https://chromiumcodereview.appspot.com/9969181/
to remove the one caller to WebSettings::setCompositeToTextureEnabled().
Adrienne Walker
Comment 3
2012-04-11 21:56:57 PDT
Comment on
attachment 136794
[details]
Patch Code changes look good to me. I am happy to get rid of this dead code.
WebKit Review Bot
Comment 4
2012-04-11 21:57:17 PDT
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 5
2012-04-11 22:18:58 PDT
Comment on
attachment 136794
[details]
Patch
Attachment 136794
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/12395047
James Robinson
Comment 6
2012-04-13 14:01:23 PDT
Committed
r114166
: <
http://trac.webkit.org/changeset/114166
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug