Bug 83733 - [chromium] Remove unused compositeToTexture / compositeOffscreen setting
Summary: [chromium] Remove unused compositeToTexture / compositeOffscreen setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 17:17 PDT by James Robinson
Modified: 2012-04-13 14:01 PDT (History)
11 users (show)

See Also:

Attachments
Patch (20.88 KB, patch)
2012-04-11 17:19 PDT, James Robinson 		enne: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-04-11 17:17:36 PDT 
[chromium] Remove unused compositeToTexture / compositeOffscreen setting
Comment 1 James Robinson 2012-04-11 17:19:17 PDT 
Created attachment 136794 [details]
Patch
Comment 2 James Robinson 2012-04-11 17:20:32 PDT 
This depends on https://chromiumcodereview.appspot.com/9969181/ to remove the one caller to WebSettings::setCompositeToTextureEnabled().
Comment 3 Adrienne Walker 2012-04-11 21:56:57 PDT 
Comment on attachment 136794 [details]
Patch

Code changes look good to me. I am happy to get rid of this dead code.
Comment 4 WebKit Review Bot 2012-04-11 21:57:17 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 WebKit Review Bot 2012-04-11 22:18:58 PDT 
Comment on attachment 136794 [details]
Patch

Attachment 136794 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12395047
Comment 6 James Robinson 2012-04-13 14:01:23 PDT 
Committed r114166: <http://trac.webkit.org/changeset/114166>