Bug 83725 - ThreadingWin: Mutex::unlock() can be "over-unlocked".
Summary: ThreadingWin: Mutex::unlock() can be "over-unlocked".
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 15:28 PDT by Jer Noble
Modified: 2012-04-12 13:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2012-04-12 11:59 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-04-11 15:28:29 PDT 
Unlocking a Mutex more times than it's m_recursionCount will result in the m_recursionCount wrapping around to MAX_INT.  There should be at least an ASSERT(m_recursionCount) in Mutex::unlock(), if not an explicit: "if (m_recursionCount) --resursionCount;"
Comment 1 Jer Noble 2012-04-12 11:59:22 PDT 
Created attachment 136949 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-12 13:35:36 PDT 
Comment on attachment 136949 [details]
Patch

Clearing flags on attachment: 136949

Committed r114028: <http://trac.webkit.org/changeset/114028>
Comment 3 WebKit Review Bot 2012-04-12 13:35:40 PDT 
All reviewed patches have been landed.  Closing bug.