Bug 83724 - REGRESSION (r113900): Text tests started failing
Summary: REGRESSION (r113900): Text tests started failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 83743
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-11 15:21 PDT by Anders Carlsson
Modified: 2012-04-12 19:51 PDT (History)
5 users (show)

See Also:


Attachments
update test results (65.68 KB, patch)
2012-04-12 11:55 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
use serif default fonts (67.55 KB, patch)
2012-04-12 16:06 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-04-11 15:21:48 PDT
After r113900, the following tests started failing:

fast/ruby/nested-ruby.html
fast/text/international/002.html
fast/text/international/font-fallback-to-common-script.html

I'm adding them to the platform/mac Skipped list.
Comment 1 Alexey Proskuryakov 2012-04-11 15:27:53 PDT
> fast/ruby/nested-ruby.html
> fast/text/international/002.html

These two likely need updated results (will confirm with pixel results).

> fast/text/international/font-fallback-to-common-script.html

This one I don't understand. Perhaps the way I'm setting standard font preference is wrong, and instead of having its own value it should reference serif or sans-serif?
Comment 2 Alexey Proskuryakov 2012-04-11 15:43:12 PDT
> fast/text/international/font-fallback-to-common-script.html

This test only works when there is no preference set for sans-serif in Chinese, which is no longer the case on Mac platform. It probably needs an addition of:

    window.internals.settings.setSansSerifFontFamily("", "Hans");
Comment 3 Matt Falkenhagen 2012-04-11 18:20:43 PDT
(In reply to comment #2)
> > fast/text/international/font-fallback-to-common-script.html
> 
> This test only works when there is no preference set for sans-serif in Chinese, which is no longer the case on Mac platform. It probably needs an addition of:
> 
>     window.internals.settings.setSansSerifFontFamily("", "Hans");


Right, my idea there was to test fallback when no setting exists from the beginning. Doing what you suggest would make the test pass, but then it would no longer be testing that scenario. Perhaps instead of lang="zh-CN", we can use a lang that's unlikely to have any setting, like:

  <div lang="und-zxxx" style="font-family: sans-serif;">
Comment 4 Alexey Proskuryakov 2012-04-12 11:55:01 PDT
Created attachment 136948 [details]
update test results

This patch updates results, but I still don't have confirmation that the new behavior is good.
Comment 5 Alexey Proskuryakov 2012-04-12 13:38:30 PDT
Comment on attachment 136948 [details]
update test results

OK, I now think that we're fine with this change.
Comment 6 Alexey Proskuryakov 2012-04-12 14:56:11 PDT
Comment on attachment 136948 [details]
update test results

Unsure again...
Comment 7 Alexey Proskuryakov 2012-04-12 16:06:14 PDT
Created attachment 136989 [details]
use serif default fonts
Comment 8 WebKit Review Bot 2012-04-12 19:51:36 PDT
Comment on attachment 136989 [details]
use serif default fonts

Clearing flags on attachment: 136989

Committed r114074: <http://trac.webkit.org/changeset/114074>
Comment 9 WebKit Review Bot 2012-04-12 19:51:41 PDT
All reviewed patches have been landed.  Closing bug.