After r113900, the following tests started failing: fast/ruby/nested-ruby.html fast/text/international/002.html fast/text/international/font-fallback-to-common-script.html I'm adding them to the platform/mac Skipped list.
> fast/ruby/nested-ruby.html > fast/text/international/002.html These two likely need updated results (will confirm with pixel results). > fast/text/international/font-fallback-to-common-script.html This one I don't understand. Perhaps the way I'm setting standard font preference is wrong, and instead of having its own value it should reference serif or sans-serif?
> fast/text/international/font-fallback-to-common-script.html This test only works when there is no preference set for sans-serif in Chinese, which is no longer the case on Mac platform. It probably needs an addition of: window.internals.settings.setSansSerifFontFamily("", "Hans");
(In reply to comment #2) > > fast/text/international/font-fallback-to-common-script.html > > This test only works when there is no preference set for sans-serif in Chinese, which is no longer the case on Mac platform. It probably needs an addition of: > > window.internals.settings.setSansSerifFontFamily("", "Hans"); Right, my idea there was to test fallback when no setting exists from the beginning. Doing what you suggest would make the test pass, but then it would no longer be testing that scenario. Perhaps instead of lang="zh-CN", we can use a lang that's unlikely to have any setting, like: <div lang="und-zxxx" style="font-family: sans-serif;">
Created attachment 136948 [details] update test results This patch updates results, but I still don't have confirmation that the new behavior is good.
Comment on attachment 136948 [details] update test results OK, I now think that we're fine with this change.
Comment on attachment 136948 [details] update test results Unsure again...
Created attachment 136989 [details] use serif default fonts
Comment on attachment 136989 [details] use serif default fonts Clearing flags on attachment: 136989 Committed r114074: <http://trac.webkit.org/changeset/114074>
All reviewed patches have been landed. Closing bug.