Bug 83719 – document.styleSheets is not updated if the document has no renderer

• Status: ASSIGNED
• Component: New Bugs

[Erik Arvidsson]

document.styleSheets is not updated if the document has no renderer

[Erik Arvidsson]

Created attachment 136758 [details]
Patch

[Erik Arvidsson]

Ryosuke: I ended up removing the helper function since this is only used in one place.

[Antti Koivisto]

Comment on attachment 136758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136758&action=review

> Source/WebCore/dom/Document.cpp:3097
> +    if (m_styleSheetsDirty) {
> +        StyleSheetVector newStylesheets;
> +        collectActiveStylesheets(newStylesheets);
> +        m_styleSheets->swap(newStylesheets);
> +        m_styleSheetsDirty = false;
> +    }
>      return m_styleSheets.get();

This seems dangerous. If we have a style selector it won't get updated and will be computing wrong style. This might never happen in practice but it is completely non-obvious why not.

It would be nice if we did not need to add new boolean as the logic is convoluted enough already.