Bug 83718 - Web Inspector: show wall time frame duration on the vertical overview
Summary: Web Inspector: show wall time frame duration on the vertical overview
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 14:14 PDT by Andrey Kosyakov
Modified: 2021-06-11 10:48 PDT (History)
12 users (show)

See Also:


Attachments
screenshot (regular frames, outliers clearly seen) (24.07 KB, image/png)
2012-04-11 14:20 PDT, Andrey Kosyakov
no flags Details
screenshot (irregular -- scrolling techcrunch back and forth) (28.32 KB, text/plain)
2012-04-11 14:20 PDT, Andrey Kosyakov
no flags Details
Patch (18.43 KB, patch)
2012-04-11 14:30 PDT, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-04-11 14:14:56 PDT
We'd like to spot frames that took long to render even in cases where CPU time usage by nested events was small, so add a contour for overall frame length to frame bars in the vertical overview.
This also requires better scaling logic, so that should we have any irregularly-long frames (i.e. in absence of requestAnimationFrame calls), these do not dwarf the rest of the frames -- so we now scale to no more than 3 * median_frame_length, which causes badly outlying frames to rocket into the sky (right in time for April, 12th).
Comment 1 Andrey Kosyakov 2012-04-11 14:20:21 PDT
Created attachment 136753 [details]
screenshot (regular frames, outliers clearly seen)
Comment 2 Andrey Kosyakov 2012-04-11 14:20:58 PDT
Created attachment 136754 [details]
screenshot (irregular -- scrolling techcrunch back and forth)
Comment 3 Andrey Kosyakov 2012-04-11 14:30:57 PDT
Created attachment 136756 [details]
Patch
Comment 4 Andrey Kosyakov 2012-04-12 09:29:54 PDT
Committed r113994: <http://trac.webkit.org/changeset/113994>