Bug 83701 – Web Inspector: Move meta node out of nodes in snapshot serialization.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexei Filippov]

Also add node_count and edge_count to eliminate arrays reallocation.

[Alexei Filippov]

Created attachment 136683 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 136683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136683&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:159
> +            delete this._snapshot.snapshot.meta;

Instead of assigning it to a new variable on this._snapshot you can leave "meta" node and access it later using  this._snapshot.snapshot.meta, what's wrong with that?

[Alexei Filippov]

Comment on attachment 136683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136683&action=review

>> Source/WebCore/inspector/front-end/HeapSnapshot.js:159
>> +            delete this._snapshot.snapshot.meta;
> 
> Instead of assigning it to a new variable on this._snapshot you can leave "meta" node and access it later using  this._snapshot.snapshot.meta, what's wrong with that?

Nothing wrong, it's just longer and I have to update it in several places. Do you insist?

[Yury Semikhatsky]

Comment on attachment 136683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136683&action=review

>>> Source/WebCore/inspector/front-end/HeapSnapshot.js:159
>>> +            delete this._snapshot.snapshot.meta;
>> 
>> Instead of assigning it to a new variable on this._snapshot you can leave "meta" node and access it later using  this._snapshot.snapshot.meta, what's wrong with that?
> 
> Nothing wrong, it's just longer and I have to update it in several places. Do you insist?

this._snapshot.metaNode is not much shorter than this._snapshot.snapshot.meta but requires additional processing of input data, and anyway you can use a local alias if a name feels long.

[Alexei Filippov]

Created attachment 136889 [details]
Patch

[WebKit Review Bot]

Comment on attachment 136889 [details]
Patch

Rejecting attachment 136889 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t 203 (offset 7 lines).
Hunk #4 succeeded at 223 (offset 7 lines).
Hunk #5 FAILED at 798.
1 out of 5 hunks FAILED -- saving rejects to file Source/WebCore/inspector/front-end/HeapSnapshot.js.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/inspector/profiler/heap-snapshot-test.js

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Yury Semik..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12395240

[Alexei Filippov]

Created attachment 136899 [details]
Patch

[WebKit Review Bot]

Comment on attachment 136899 [details]
Patch

Clearing flags on attachment: 136899

Committed r113988: <http://trac.webkit.org/changeset/113988>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.