RESOLVED FIXED Bug 83700
Web Inspector: add closure compiler annotations for profiler code 
https://bugs.webkit.org/show_bug.cgi?id=83700
Summary Web Inspector: add closure compiler annotations for profiler code
Yury Semikhatsky
Reported 2012-04-11 09:36:10 PDT
Add closure compiler annotations for profiler code.
Attachments
Patch (49.60 KB, patch)
2012-04-11 09:37 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-04-11 09:37:31 PDT
Created attachment 136678 [details] Patch
Pavel Feldman
Comment 2 2012-04-11 12:43:03 PDT
Comment on attachment 136678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136678&action=review > Source/WebCore/inspector/front-end/DetailedHeapshotView.js:32 > + * @param {boolean=} deferNodeContentCreation @param should be below the @constructor and @extends > Source/WebCore/inspector/front-end/ProfilesPanel.js:102 > + * @constructor Annotating parameter types while you are here might make type checking more complete.
Yury Semikhatsky
Comment 3 2012-04-12 04:49:32 PDT
(In reply to comment #2) > (From update of attachment 136678 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136678&action=review > > > Source/WebCore/inspector/front-end/DetailedHeapshotView.js:32 > > + * @param {boolean=} deferNodeContentCreation > > @param should be below the @constructor and @extends > Done. > > Source/WebCore/inspector/front-end/ProfilesPanel.js:102 > > + * @constructor > > Annotating parameter types while you are here might make type checking more complete. Done.
Yury Semikhatsky
Comment 4 2012-04-12 05:04:06 PDT
Committed r113963: <http://trac.webkit.org/changeset/113963>
Note You need to log in before you can comment on or make changes to this bug.