Bug 83690 – webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jocelyn Turcotte]

webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc

[Jocelyn Turcotte]

Created attachment 136667 [details]
Patch

[Jocelyn Turcotte]

Created attachment 136880 [details]
Patch

- Use print() instead of print_
- Use COMP_WORDS directly in __webkit-patch_upload_cc_generate_reply like __webkit-patch_generate_reply does

[Tor Arne Vestbø]

Comment on attachment 136880 [details]
Patch

lgtm, minus the comment thing

[Jocelyn Turcotte]

Committed r114120: <http://trac.webkit.org/changeset/114120>

[Csaba Osztrogonác]

The title of the bug and the committ log is incorrect, because it 
only completes options, not email addresses now. Otherwise the
idea is very good, email competion in bash is cool. ;)

[Jocelyn Turcotte]

(In reply to comment #5)
Well it should, so if it doesn't then it's broken in some cases.
Did you try to re- source Tools/Scripts/webkit-tools-completion.sh ?

[Csaba Osztrogonác]

(In reply to comment #6)
> (In reply to comment #5)
> Well it should, so if it doesn't then it's broken in some cases.
> Did you try to re- source Tools/Scripts/webkit-tools-completion.sh ?

I made some digging, and there were two problems here:
- I copied this script to /etc/bash_completion.d to make it system wide,
but unfortunaly it doesn't work, because the search path of committers.py 
is relative to webkit-tools-completion.sh.
- I thought that completion works similar to cc field on bugzilla and I 
tried to use it with real names and nicknames. But it seems it understands
only email addressess.

[Jocelyn Turcotte]

(In reply to comment #7)
> I made some digging, and there were two problems here:
> - I copied this script to /etc/bash_completion.d to make it system wide,
> but unfortunaly it doesn't work, because the search path of committers.py 
> is relative to webkit-tools-completion.sh.
Ah ok, do you know if many people use it that way?
Using an environment variable to point to committers.py would be pretty crappy, but maybe it would be possible to extract the path from the first token in $COMP_WORDS. What I mean is to try finding committers.py relatively to webkit-patch instead of webkit-tools-completion.sh.

> - I thought that completion works similar to cc field on bugzilla and I 
> tried to use it with real names and nicknames. But it seems it understands
> only email addressess.
I talked with Tor Arne about it too but bash haven't designed their completion extension to make this work reliably. It works better with completing than replacing text. So from my point of view it's better to keep it limited and reliable.