Bug 83687 – [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

EFL's LayoutTestController needs setJavaScriptCanAccessClipboard implementation, so that it is possible to unskip
editing/execCommand/clipboard-access.html

[Mikhail Pozdnyakov]

Created attachment 136850 [details]
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

Keeping ewk_view_setting family, as the approach proposed in https://bugs.webkit.org/show_bug.cgi?id=83007 is not agreed yet.

[Gyuyoung Kim]

Comment on attachment 136850 [details]
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

Attachment 136850 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12391343

[Mikhail Pozdnyakov]

Created attachment 136874 [details]
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

[Gyuyoung Kim]

Comment on attachment 136874 [details]
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

Other ports(e.g. blackberry, mac, gtk and qt) support this setting APis. Looks fine except for description in ChangeLog.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 136874 [details]
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

Looks fine, thanks.

[WebKit Review Bot]

Comment on attachment 136874 [details]
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

Rejecting attachment 136874 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
jects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej
patching file Source/WebKit/efl/ewk/ewk_view.h
Hunk #1 succeeded at 1555 (offset 53 lines).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
Hunk #1 succeeded at 332 with fuzz 1 (offset 12 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12613326

[Mikhail Pozdnyakov]

Created attachment 140430 [details]
to be landed.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 140430 [details]
to be landed.

cq+'ing. I strongly recommend using webkit-patch to upload your patches instead of doing so manually; besides it making the whole process much quicker, it also marks previous patches as obsolete, which you sometimes forget to do.

[WebKit Review Bot]

Comment on attachment 140430 [details]
to be landed.

Clearing flags on attachment: 140430

Committed r116250: <http://trac.webkit.org/changeset/116250>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.