Bug 83685 – Calendar Picker: remove unnecessary code from calendarPicker.{css,js}

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Calendar Picker: remove unnecessary code from calendarPicker.{css,js}

[Kent Tamura]

Created attachment 136651 [details]
Patch

[Kentaro Hara]

Comment on attachment 136651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136651&action=review

> Source/WebCore/ChangeLog:12
> +         - leading adn trailing whitespace (.js and .css)

Nit: *and*

> Source/WebCore/make-file-arrays.py:59
> +    leading_space = re.compile(r"^ ", re.MULTILINE)

This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better.

> Source/WebCore/make-file-arrays.py:60
> +    trailing_space = re.compile(r" $", re.MULTILINE)

Ditto. r"[ \t]+$" might be better.

> Source/WebCore/make-file-arrays.py:75
> +        print content

Remove this

[Kent Tamura]

Committed r114090: <http://trac.webkit.org/changeset/114090>

[Kent Tamura]

(In reply to comment #2)
> > Source/WebCore/ChangeLog:12
> > +         - leading adn trailing whitespace (.js and .css)
> 
> Nit: *and*

Fixed.

> > Source/WebCore/make-file-arrays.py:59
> > +    leading_space = re.compile(r"^ ", re.MULTILINE)
> 
> This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better.

Fixed.

> > Source/WebCore/make-file-arrays.py:60
> > +    trailing_space = re.compile(r" $", re.MULTILINE)
> 
> Ditto. r"[ \t]+$" might be better.

Fixed.

> > Source/WebCore/make-file-arrays.py:75
> > +        print content
> 
> Remove this

Removed.