Bug 83685 - Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
Summary: Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 53961
  Show dependency treegraph
 
Reported: 2012-04-11 03:14 PDT by Kent Tamura
Modified: 2012-04-12 23:34 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.21 KB, patch)
2012-04-11 03:19 PDT, Kent Tamura
haraken: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-04-11 03:14:17 PDT
Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
Comment 1 Kent Tamura 2012-04-11 03:19:58 PDT
Created attachment 136651 [details]
Patch
Comment 2 Kentaro Hara 2012-04-11 04:09:29 PDT
Comment on attachment 136651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136651&action=review

> Source/WebCore/ChangeLog:12
> +         - leading adn trailing whitespace (.js and .css)

Nit: *and*

> Source/WebCore/make-file-arrays.py:59
> +    leading_space = re.compile(r"^ ", re.MULTILINE)

This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better.

> Source/WebCore/make-file-arrays.py:60
> +    trailing_space = re.compile(r" $", re.MULTILINE)

Ditto. r"[ \t]+$" might be better.

> Source/WebCore/make-file-arrays.py:75
> +        print content

Remove this
Comment 3 Kent Tamura 2012-04-12 23:33:30 PDT
Committed r114090: <http://trac.webkit.org/changeset/114090>
Comment 4 Kent Tamura 2012-04-12 23:34:36 PDT
(In reply to comment #2)
> > Source/WebCore/ChangeLog:12
> > +         - leading adn trailing whitespace (.js and .css)
> 
> Nit: *and*

Fixed.

> > Source/WebCore/make-file-arrays.py:59
> > +    leading_space = re.compile(r"^ ", re.MULTILINE)
> 
> This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better.

Fixed.

> > Source/WebCore/make-file-arrays.py:60
> > +    trailing_space = re.compile(r" $", re.MULTILINE)
> 
> Ditto. r"[ \t]+$" might be better.

Fixed.

> > Source/WebCore/make-file-arrays.py:75
> > +        print content
> 
> Remove this

Removed.