Bug 83670 - [BlackBerry] There shouldn't be two or more Accept-Language in platformRequest's headerList.
Summary: [BlackBerry] There shouldn't be two or more Accept-Language in platformReques...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 00:04 PDT by Jason Liu
Modified: 2012-04-11 20:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2012-04-11 00:42 PDT, Jason Liu 		no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2012-04-11 19:12 PDT, Jason Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Liu 2012-04-11 00:04:11 PDT 
We add Accept-Language to platformRequest in initializePlatformRequest.
But need to make sure there aren't two or more Accecpt-Language in headerList.
Comment 1 Jason Liu 2012-04-11 00:42:03 PDT 
Created attachment 136637 [details]
Patch
Comment 2 Charles Wei 2012-04-11 02:44:44 PDT 
Comment on attachment 136637 [details]
Patch

Looks good to me.  Need a reviewer to approve though.
Comment 3 Rob Buis 2012-04-11 04:22:38 PDT 
Comment on attachment 136637 [details]
Patch

Looks good. But why is this called twice? Can't the state be checked before calling twice?
Comment 4 Jason Liu 2012-04-11 19:08:23 PDT 
(In reply to comment #3)
> (From update of attachment 136637 [details])
> Looks good. But why is this called twice? Can't the state be checked before calling twice?

It is called to add custom headers to resourceRequest first. Accept-Language is in header list.
When we create a platformRequest, it is called again.
Comment 5 Jason Liu 2012-04-11 19:12:49 PDT 
Created attachment 136807 [details]
Patch
Comment 6 Leo Yang 2012-04-11 19:34:47 PDT 
Comment on attachment 136807 [details]
Patch

Since you addressed Rob's comments when he gave you r+, I cq+ your patch.
Comment 7 WebKit Review Bot 2012-04-11 20:06:39 PDT 
Comment on attachment 136807 [details]
Patch

Clearing flags on attachment: 136807

Committed r113938: <http://trac.webkit.org/changeset/113938>
Comment 8 WebKit Review Bot 2012-04-11 20:06:43 PDT 
All reviewed patches have been landed.  Closing bug.