RESOLVED FIXED 83669
[EFL] dispatchDidCancelClientRedirect needs implementation 
https://bugs.webkit.org/show_bug.cgi?id=83669
Summary [EFL] dispatchDidCancelClientRedirect needs implementation
Chris Dumez
Reported 2012-04-11 00:02:23 PDT
A signal needs to be emitted in EFL FrameLoaderClient's dispatchDidCancelClientRedirect(). This signal needs to be caught in the DumpRenderTree so that "didCancelClientRedirectForFrame" are printed if the LayoutTestControler's dumpFrameLoadCallbacks is set to true.
Attachments
Patch (7.45 KB, patch)
2012-04-19 03:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.29 KB, patch)
2012-04-19 03:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-04-19 03:00:31 PDT
Created attachment 137867 [details] Patch This patch improves the dumpFrameLoadCallbacks() output expected by the following test cases: didCancelClientRedirectForFrame: http/tests/loading/onload-vs-immediate-refresh.html http/tests/loading/deleted-host-in-resource-load-delegate-callback.html http/tests/loading/307-after-303-after-post.html http/tests/loading/redirect-methods.html http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html http/tests/globalhistory/history-delegate-basic-refresh-redirect.html http/tests/globalhistory/history-delegate-basic-302-redirect.html webarchive/loading/javascript-url-iframe-crash.html Unfortunately, none of these tests can be unskipped yet because they require other features (in particular dumpResourceLoadCallbacks() from #81891).
Grzegorz Czajkowski
Comment 2 2012-04-19 03:11:42 PDT
Generally is OK. View in context: https://bugs.webkit.org/attachment.cgi?id=137867&action=review > Source/WebKit/efl/ChangeLog:3 > + Bug 83669 - [EFL] dispatchDidCancelClientRedirect needs implementation Unnecessary line. > Tools/ChangeLog:3 > + Bug 83669 - [EFL] dispatchDidCancelClientRedirect needs implementation Ditto.
Chris Dumez
Comment 3 2012-04-19 03:37:52 PDT
Created attachment 137870 [details] Patch Fixed Changelogs
Grzegorz Czajkowski
Comment 4 2012-04-19 04:59:53 PDT
Thanks for changes, LGTM.
WebKit Review Bot
Comment 5 2012-04-19 08:37:33 PDT
Comment on attachment 137870 [details] Patch Clearing flags on attachment: 137870 Committed r114633: <http://trac.webkit.org/changeset/114633>
WebKit Review Bot
Comment 6 2012-04-19 08:37:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.