Bug 83667 – Add layout test case for audioChannelSplitter.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Raymond]

Add layout test case for audioChannelSplitter.

[Raymond]

Created attachment 136633 [details]
Patch

[WebKit Review Bot]

Comment on attachment 136633 [details]
Patch

Attachment 136633 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12381761

New failing tests:
webaudio/audiochannelsplitter.html

[WebKit Review Bot]

Created attachment 136638 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Raymond]

(In reply to comment #3)
hmm, layout test fail is expected since 83648 is not landed yet. Will try to trigger bot again when 83648 landed.

[Chris Rogers]

Comment on attachment 136633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136633&action=review

Test looks great overall - some minor nits:

> LayoutTests/ChangeLog:3
> +        Add layout test case for audioChannelSplitter.

nit: audioChannelSplitter -> AudioChannelSplitter

> LayoutTests/webaudio/audiochannelsplitter-expected.txt:1
> +Tests that audio channel splitter working correctly.

"Tests that audio channel splitter working correctly" -> "Tests AudioChannelSplitter"

> LayoutTests/webaudio/audiochannelsplitter.html:4
> +Tests that audioChannelSplitter working correctly.

audioChannelSplitter -> AudioChannelSplitter

> LayoutTests/webaudio/audiochannelsplitter.html:31
> +

nit: extra blank line

> LayoutTests/webaudio/audiochannelsplitter.html:46
> +// checkResult() checks that the rendered buffer is stereo and that the left channel is all -1 and right channel all +1.

I'd add an additional comment line:
// In other words, we've reversed the order of the two channels.

> LayoutTests/webaudio/audiochannelsplitter.html:68
> +        testPassed("Correctly exchange stereo streams channel layout.");

"Correctly exchange stereo streams channel layout." -> "Correctly exchanged left and right channels."

> LayoutTests/webaudio/audiochannelsplitter.html:70
> +        testFailed("Error on exchanging stereo streams channel layout.");

ditto

> LayoutTests/webaudio/audiochannelsplitter.html:115
> +    // When Merging, exchange channel layout: left->right, right->left

Merging -> merging

[Raymond]

Patch been merged to https://bugs.webkit.org/show_bug.cgi?id=83648. Since that one been landed. close this one.

[Eric Seidel (no email)]

Comment on attachment 136633 [details]
Patch

Cleared review? from attachment 136633 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).