Bug 83658 - [chromium] Add OVERRIDE annotations for cc layer types
Summary: [chromium] Add OVERRIDE annotations for cc layer types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks: 83645
  Show dependency tree / graph
 
Reported: 2012-04-10 19:46 PDT by James Robinson
Modified: 2012-04-11 13:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (30.27 KB, patch)
2012-04-10 19:48 PDT, James Robinson 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-04-10 19:46:00 PDT 
[chromium] Add OVERRIDE annotations for cc layer types
Comment 1 James Robinson 2012-04-10 19:48:03 PDT 
Created attachment 136611 [details]
Patch
Comment 2 Daniel Bates 2012-04-10 21:24:44 PDT 
Comment on attachment 136611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136611&action=review

> Source/WebKit/chromium/ChangeLog:14
> +        * src/WebLayerImpl.cpp:
> +        * src/WebLayerImpl.h:

For your consideration I suggest adding a remark to the right of these files to explain that you are removing the function WebLayerImpl::paintContents() instead of adding an override annotation to it.
Comment 3 James Robinson 2012-04-11 13:20:08 PDT 
Committed r113902: <http://trac.webkit.org/changeset/113902>