Bug 83655 - Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
Summary: Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 73011
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-10 19:28 PDT by Kenneth Russell
Modified: 2012-04-25 15:12 PDT (History)
11 users (show)

See Also:


Attachments
Patch for EWS bots (122.51 KB, patch)
2012-04-25 10:47 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff
Patch (122.54 KB, patch)
2012-04-25 13:26 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2012-04-10 19:28:06 PDT
Once https://bugs.webkit.org/show_bug.cgi?id=73011 is fixed, ByteArray, JSByteArray and a bunch of JSC code dealing with CanvasPixelArray will be unreferenced and can be deleted. This is being separated out from the cutover in order to keep the sizes of the patches manageable.
Comment 1 Kenneth Russell 2012-04-25 10:47:38 PDT
Created attachment 138842 [details]
Patch for EWS bots
Comment 2 Early Warning System Bot 2012-04-25 10:57:48 PDT
Comment on attachment 138842 [details]
Patch for EWS bots

Attachment 138842 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12517642
Comment 3 Early Warning System Bot 2012-04-25 11:46:27 PDT
Comment on attachment 138842 [details]
Patch for EWS bots

Attachment 138842 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12521598
Comment 4 Kenneth Russell 2012-04-25 13:26:10 PDT
Created attachment 138867 [details]
Patch
Comment 5 Kenneth Russell 2012-04-25 13:26:52 PDT
Here's the patch. I'm quite pleased with the amount of code that was able to be deleted. Please review.
Comment 6 Noam Rosenthal 2012-04-25 14:02:23 PDT
Thanks for not leaving the qt ews red!
Comment 7 Kenneth Russell 2012-04-25 14:23:13 PDT
(In reply to comment #6)
> Thanks for not leaving the qt ews red!

Of course of course!
Comment 8 WebKit Review Bot 2012-04-25 15:12:10 PDT
Comment on attachment 138867 [details]
Patch

Clearing flags on attachment: 138867

Committed r115248: <http://trac.webkit.org/changeset/115248>
Comment 9 WebKit Review Bot 2012-04-25 15:12:24 PDT
All reviewed patches have been landed.  Closing bug.