WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83633
Remove webkit prefix from Media Source runtime feature name.
https://bugs.webkit.org/show_bug.cgi?id=83633
Summary
Remove webkit prefix from Media Source runtime feature name.
Aaron Colwell
Reported
2012-04-10 15:52:57 PDT
The Media Source methods have a webkit prefix on their runtime feature names which is a no-no. This bug is for the patch to remove the prefix.
Attachments
Patch
(5.92 KB, patch)
2012-04-10 15:54 PDT
,
Aaron Colwell
no flags
Details
Formatted Diff
Diff
Removed OOPS line to make style bot happy.
(5.92 KB, patch)
2012-04-11 08:34 PDT
,
Aaron Colwell
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Aaron Colwell
Comment 1
2012-04-10 15:54:42 PDT
Created
attachment 136561
[details]
Patch
Adam Barth
Comment 2
2012-04-10 15:56:03 PDT
Comment on
attachment 136561
[details]
Patch Thanks!
WebKit Review Bot
Comment 3
2012-04-10 15:58:14 PDT
Attachment 136561
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 4
2012-04-10 20:40:34 PDT
Comment on
attachment 136561
[details]
Patch Rejecting
attachment 136561
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: git/webkit-commit-queue/Source/WebKit/chromium/ui --revision 131469 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 131469. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output:
http://queues.webkit.org/results/12383607
Adam Barth
Comment 5
2012-04-10 20:44:12 PDT
Comment on
attachment 136561
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=136561&action=review
>> Source/WebCore/ChangeLog:8 >> + No new tests. (OOPS!) > > You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
The style queue is right! We'll need to remove this line before landing.
Aaron Colwell
Comment 6
2012-04-11 08:34:56 PDT
Created
attachment 136674
[details]
Removed OOPS line to make style bot happy.
WebKit Review Bot
Comment 7
2012-04-11 10:33:11 PDT
Comment on
attachment 136674
[details]
Removed OOPS line to make style bot happy. Clearing flags on attachment: 136674 Committed
r113875
: <
http://trac.webkit.org/changeset/113875
>
WebKit Review Bot
Comment 8
2012-04-11 10:33:15 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug