Bug 83625 – Remove unused WebVideoFrame::Format values

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ami Fischman]

http://code.google.com/p/chromium/issues/detail?id=108306 removes RGB555/RGB565/RGB24/RGBA/NV12/ASCII from media::VideoFrame::Format because they were unused (except for test code, sometimes).  IWBN to drop these formats from webkit, as well.

[Ami Fischman]

Created attachment 136556 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kenneth Russell]

Comment on attachment 136556 [details]
Patch

Looks fine. r=me

[Ami Fischman]

Comment on attachment 136556 [details]
Patch

(removed cq? b/c the chromium side needs to land first; I'll cq+ when that happens assuming the API review doesn't snag up)

[Adam Barth]

Comment on attachment 136556 [details]
Patch

LGTM2

[Ami Fischman]

Comment on attachment 136556 [details]
Patch

Chromium-side landed in http://crrev.com/131682

[Ami Fischman]

Comment on attachment 136556 [details]
Patch

...err, except landing in chromium isn't enough, it also needs to roll into webkit's chromium DEPS.  Putting back on hold.

[WebKit Review Bot]

Comment on attachment 136556 [details]
Patch

Attachment 136556 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12379814

[Ami Fischman]

Comment on attachment 136556 [details]
Patch

cr-ews failure was due to being kicked off before the roll.  Should be good now.

[WebKit Review Bot]

Comment on attachment 136556 [details]
Patch

Rejecting attachment 136556 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Frame'
Source/WebKit/chromium/webkit/media/webvideoframe_impl.cc:45: error: template argument 1 is invalid
Source/WebKit/chromium/webkit/media/webvideoframe_impl.cc:45: error: 'FormatASCII' is not a member of 'WebKit::WebVideoFrame'
Source/WebKit/chromium/webkit/media/webvideoframe_impl.cc:45: error: invalid type in declaration before ';' token
make: *** [out/Debug/obj.target/webkit_media/Source/WebKit/chromium/webkit/media/webvideoframe_impl.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/12383625

[Ami Fischman]

Comment on attachment 136556 [details]
Patch

Roll actually landed now...

[WebKit Review Bot]

Comment on attachment 136556 [details]
Patch

Rejecting attachment 136556 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 131684 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 131684.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12379924

[Ami Fischman]

Comment on attachment 136556 [details]
Patch

If at first you don't succeed (connecting to svn.webkit.org) try, try again!

[WebKit Review Bot]

Comment on attachment 136556 [details]
Patch

Clearing flags on attachment: 136556

Committed r113865: <http://trac.webkit.org/changeset/113865>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.