Bug 83624 – Layout Test webaudio/* is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jer Noble]

The following layout tests are flaky on chromium-win

webaudio/audiobuffersource-playbackState.html
webaudio/audiochannelmerger-stereo.html
webaudio/audioparam-exponentialRampToValueAtTime.html
webaudio/audioparam-linearRampToValueAtTime.html
webaudio/audioparam-setTargetValueAtTime.html
webaudio/audioparam-setValueAtTime.html
webaudio/audioparam-setValueCurveAtTime.html
webaudio/convolution-mono-mono.html
webaudio/delaynode-maxdelay.html
webaudio/delaynode-scheduling.html
webaudio/delaynode.html
webaudio/note-grain-on-play.html
webaudio/note-grain-on-timing.html

Probable cause:

https://bugs.webkit.org/show_bug.cgi?id=74553 & http://trac.webkit.org/changeset/113728

[Jer Noble]

Added failing test to test_expectations.txt in <http://trac.webkit.org/changeset/113776>.

[Jer Noble]

Created attachment 136769 [details]
Patch

[Raymond Toy]

(In reply to comment #2)
> Created an attachment (id=136769) [details]
> Patch

I've tested this patch using a chromium-win debug build, and all the tests pass.  This is a *critically* important fix because it also pretty much breaks all of webaudio.  All webaudio demos are broken. because of this.

[Jer Noble]

Created attachment 136771 [details]
Patch

Rebased.

[Chris Rogers]

Comment on attachment 136771 [details]
Patch

Thanks Jer

[Chris Rogers]

Jer, do you want me to put this in commit queue?

[Jer Noble]

(In reply to comment #6)
> Jer, do you want me to put this in commit queue?

I got it, thanks. :)

[WebKit Review Bot]

Comment on attachment 136771 [details]
Patch

Clearing flags on attachment: 136771

Committed r113933: <http://trac.webkit.org/changeset/113933>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.