Bug 83614 - REGRESSION (r108364): Tables on wikipedia not centering properly
Summary: REGRESSION (r108364): Tables on wikipedia not centering properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Critical
Assignee: Dave Hyatt
URL: http://en.wikipedia.org/wiki/Towel_day
Keywords: InRadar
Depends on:
Blocks: 89515
  Show dependency tree / graph
 
Reported: 2012-04-10 13:30 PDT by Dave Hyatt
Modified: 2012-06-19 14:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.53 KB, patch)
2012-04-10 13:30 PDT, Dave Hyatt 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (6.41 MB, application/zip)
2012-04-10 19:25 PDT, WebKit Review Bot 		no flags Details
Patch (1.42 MB, patch)
2012-04-11 11:00 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (38.01 KB, patch)
2012-04-11 11:03 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2012-04-10 13:30:10 PDT 
go to http://en.wikipedia.org/wiki/Towel_day
-> the quotation showing the origin overlaps the box on the right, regardless of how wide you make the window.

In Radar as:
<rdar://problem/11177351> REGRESSION (r108364): Text overlaps the box on the right
Comment 1 Dave Hyatt 2012-04-10 13:30:42 PDT 
Created attachment 136524 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-10 14:23:50 PDT 
We'll need a test.
Comment 3 Dave Hyatt 2012-04-10 14:28:27 PDT 
(In reply to comment #2)
> We'll need a test.

It's not up for review yet. Checking ews first.
Comment 4 WebKit Review Bot 2012-04-10 19:25:52 PDT 
Comment on attachment 136524 [details]
Patch

Attachment 136524 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12381621

New failing tests:
css2.1/20110323/replaced-elements-001.htm
fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html
Comment 5 WebKit Review Bot 2012-04-10 19:25:58 PDT 
Created attachment 136607 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 Dave Hyatt 2012-04-11 11:00:43 PDT 
Created attachment 136704 [details]
Patch
Comment 7 Dave Hyatt 2012-04-11 11:03:30 PDT 
Created attachment 136707 [details]
Patch
Comment 8 mitz 2012-04-11 11:26:12 PDT 
Comment on attachment 136707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136707&action=review

> LayoutTests/ChangeLog:14
> +        * platform/mac/fast/block/float/avoiding-float-centered-expected.png: Added.
> +        * platform/mac/fast/block/float/avoiding-float-centered-expected.txt: Added.

Could be a ref test :)
Comment 9 Dave Hyatt 2012-04-11 11:37:04 PDT 
Fixed in r113885.
Comment 10 Eric Seidel (no email) 2012-06-19 14:02:53 PDT 
Note that this caused at least one change in behavior in eveonline.com:
http://code.google.com/p/chromium/issues/detail?id=130069