Bug 83612 – Split CSSStyleSheet into internal and CSSOM type

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

This will complete the separation of our style sheet data structures from CSSOM.

[Antti Koivisto]

Created attachment 136592 [details]
patch

[WebKit Review Bot]

Attachment 136592 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.h:73:  The parameter name "ruleRangeMap" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSParser.h:81:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.cpp:1025:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSheet.h:135:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSheet.h:135:  The parameter name "rule" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSheet.h:183:  The parameter name "b" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSheet.cpp:174:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 7 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 136592 [details]
patch

Attachment 136592 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12386129

[Early Warning System Bot]

Comment on attachment 136592 [details]
patch

Attachment 136592 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12380651

[WebKit Review Bot]

Comment on attachment 136592 [details]
patch

Attachment 136592 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12380718

[Antti Koivisto]

Created attachment 136666 [details]
rebased

[WebKit Review Bot]

Attachment 136666 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.h:81:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.cpp:1025:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 136666 [details]
rebased

Attachment 136666 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12387070

[Antti Koivisto]

Created attachment 136670 [details]
try to fix chromium build

[WebKit Review Bot]

Attachment 136670 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.h:81:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.cpp:1025:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 136670 [details]
try to fix chromium build

Attachment 136670 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12380927

[Antti Koivisto]

It looks like V8 bindings are using WebCore::StyleSheetInternal as a namespace name :(

[Antti Koivisto]

The name collision was fixed in http://trac.webkit.org/changeset/113881

[Antti Koivisto]

Created attachment 136708 [details]
resubmitting for bots

[WebKit Review Bot]

Attachment 136708 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.h:81:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.cpp:1025:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 136708 [details]
resubmitting for bots

View in context: https://bugs.webkit.org/attachment.cgi?id=136670&action=review

> Source/WebCore/css/CSSStyleSheet.cpp:510
> +        m_childRuleCSSOMWrappers[index]->setParentStyleSheet(0);

We're gonna need a null check here, since this particular wrapper may not have been instantiated.

> Source/WebCore/dom/ProcessingInstruction.cpp:240
> +    else if (m_isXSL)
> +        static_cast<XSLStyleSheet*>(m_sheet.get())->parseString(sheet, CSSStrictMode);

This looks silly, XSLStyleSheet shouldn't be taking a CSSParserMode.

> Source/WebCore/xml/XSLStyleSheet.h:74
> +    virtual bool isLoading() const;

Should add OVERRIDE while we are touching this.

[Antti Koivisto]

(In reply to comment #16)
> (From update of attachment 136708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136670&action=review
> 
> > Source/WebCore/css/CSSStyleSheet.cpp:510
> > +        m_childRuleCSSOMWrappers[index]->setParentStyleSheet(0);
> 
> We're gonna need a null check here, since this particular wrapper may not have been instantiated.

This bug was already in existing code. Fixed separately in http://trac.webkit.org/changeset/113898.

[Antti Koivisto]

Created attachment 136741 [details]
try to fix chromium build

[WebKit Review Bot]

Attachment 136741 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.h:81:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.cpp:1025:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 136778 [details]
fix a crashing test

[WebKit Review Bot]

Attachment 136778 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSParser.h:81:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSParser.cpp:1025:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

http://trac.webkit.org/changeset/113922