Bug 83611 – [Cairo] Wrap cairo surfaces in a class when storing native images

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Martin Robinson]

When WebCore stores an image in the "native format" now it stores a Cairo surface. By storing a class that we control, we can store cached versions that have been resampled or created for different backends. This follows the Skia backend's approach.

[Martin Robinson]

Created attachment 136550 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 136550 [details]
Patch

Attachment 136550 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12379786

[Martin Robinson]

Created attachment 136688 [details]
Try to fix the EFL build

[Gyuyoung Kim]

Comment on attachment 136688 [details]
Try to fix the EFL build

Attachment 136688 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12382928

[Martin Robinson]

Created attachment 136703 [details]
Try once again to fix the EFL build

[Gyuyoung Kim]

Comment on attachment 136703 [details]
Try once again to fix the EFL build

Attachment 136703 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12383937

[Martin Robinson]

Created attachment 136746 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 136746 [details]
Patch

Attachment 136746 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12385858

[Martin Robinson]

Created attachment 137417 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 137417 [details]
Patch

Attachment 137417 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12417280

[Martin Robinson]

Created attachment 137434 [details]
One more time

[Alejandro G. Castro]

Comment on attachment 137434 [details]
One more time

View in context: https://bugs.webkit.org/attachment.cgi?id=137434&action=review

Looks good to me, you have to check TextureMapperGL.cpp compilation, it requires a modification to compile.

> Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp:2
> + * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.

Check if the copyright is the same in the original file.

[Martin Robinson]

Created attachment 138243 [details]
Patch

[Alejandro G. Castro]

Comment on attachment 138243 [details]
Patch

Great LGTM

[WebKit Review Bot]

Comment on attachment 138243 [details]
Patch

Rejecting attachment 138243 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Alejandro G found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12530640

[Martin Robinson]

Comment on attachment 138243 [details]
Patch

Clearing flags on attachment: 138243

Committed r115385: <http://trac.webkit.org/changeset/115385>

[Martin Robinson]

All reviewed patches have been landed.  Closing bug.