Need WebKit2 API to notify whether history loads are in the page cache This should be in the bundle and leverage FrameLoaderClient::shouldGoToHistoryItem In radar as <rdar://problem/11176921>
Created attachment 136506 [details] Patch v1 - Fix plus API test
Attachment 136506 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:39: The parameter name "bundle" adds no information, so it should be removed. [readability/parameter_name] [5] Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:39: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 136506 [details] Patch v1 - Fix plus API test Attachment 136506 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12376930
Created attachment 136525 [details] Patch v2 - Now with more Qt build fixes
Attachment 136525 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:39: The parameter name "bundle" adds no information, so it should be removed. [readability/parameter_name] [5] Tools/TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:39: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 136525 [details] Patch v2 - Now with more Qt build fixes View in context: https://bugs.webkit.org/attachment.cgi?id=136525&action=review > Source/WebKit2/UIProcess/API/C/WKPage.h:74 > -typedef void (*WKPageWillGoToBackForwardListItemCallback)(WKPageRef page, WKBackForwardListItemRef item, const void *clientInfo); > +typedef void (*WKPageWillGoToBackForwardListItemCallback)(WKPageRef page, WKBackForwardListItemRef item, WKTypeRef userData, const void *clientInfo); Are there any existing clients that would now have binary incompatibility? Or is this already something new?
(In reply to comment #6) > (From update of attachment 136525 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136525&action=review > > > Source/WebKit2/UIProcess/API/C/WKPage.h:74 > > -typedef void (*WKPageWillGoToBackForwardListItemCallback)(WKPageRef page, WKBackForwardListItemRef item, const void *clientInfo); > > +typedef void (*WKPageWillGoToBackForwardListItemCallback)(WKPageRef page, WKBackForwardListItemRef item, WKTypeRef userData, const void *clientInfo); > > Are there any existing clients that would now have binary incompatibility? Or is this already something new? Less than two months old, added in http://trac.webkit.org/changeset/108570 Thanks for the review!
http://trac.webkit.org/changeset/114143