Bug 83592 - [Qt] InspectorServer: Improve the page list's parameter names
Summary: [Qt] InspectorServer: Improve the page list's parameter names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-10 10:22 PDT by Jocelyn Turcotte
Modified: 2012-04-11 07:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.47 KB, patch)
2012-04-10 10:27 PDT, Jocelyn Turcotte
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-04-10 10:22:33 PDT
[Qt] InspectorServer: Improve the page list's parameter names
Comment 1 Jocelyn Turcotte 2012-04-10 10:27:59 PDT
Created attachment 136484 [details]
Patch
Comment 2 Simon Hausmann 2012-04-11 01:23:56 PDT
Comment on attachment 136484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136484&action=review

> Source/WebKit2/qt/Resources/inspectorPageIndex.html:14
> +                var description = pages[i].title ? pages[i].title : ("Page " + (Number(pages[i].id)));

Wouldn't it make sense to rename the local description variable to title, too?
Comment 3 Jocelyn Turcotte 2012-04-11 02:40:21 PDT
(In reply to comment #2)
> Wouldn't it make sense to rename the local description variable to title, too?

Oh I thought the url was in it too, it's only added later, yep I'll do.
Thx!
Comment 4 Jocelyn Turcotte 2012-04-11 07:52:42 PDT
Committed r113860: <http://trac.webkit.org/changeset/113860>