RESOLVED FIXED 83592
[Qt] InspectorServer: Improve the page list's parameter names 
https://bugs.webkit.org/show_bug.cgi?id=83592
Summary [Qt] InspectorServer: Improve the page list's parameter names
Jocelyn Turcotte
Reported 2012-04-10 10:22:33 PDT
[Qt] InspectorServer: Improve the page list's parameter names
Attachments
Patch (3.47 KB, patch)
2012-04-10 10:27 PDT, Jocelyn Turcotte 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-04-10 10:27:59 PDT
Created attachment 136484 [details] Patch
Simon Hausmann
Comment 2 2012-04-11 01:23:56 PDT
Comment on attachment 136484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136484&action=review > Source/WebKit2/qt/Resources/inspectorPageIndex.html:14 > + var description = pages[i].title ? pages[i].title : ("Page " + (Number(pages[i].id))); Wouldn't it make sense to rename the local description variable to title, too?
Jocelyn Turcotte
Comment 3 2012-04-11 02:40:21 PDT
(In reply to comment #2) > Wouldn't it make sense to rename the local description variable to title, too? Oh I thought the url was in it too, it's only added later, yep I'll do. Thx!
Jocelyn Turcotte
Comment 4 2012-04-11 07:52:42 PDT
Committed r113860: <http://trac.webkit.org/changeset/113860>
Note You need to log in before you can comment on or make changes to this bug.