Bug 83587 - [Qt] Fix issues when using the WebView as ShaderEffectSource
Summary: [Qt] Fix issues when using the WebView as ShaderEffectSource
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
Depends on: 83591
  Show dependency treegraph
Reported: 2012-04-10 09:36 PDT by Jocelyn Turcotte
Modified: 2012-04-11 07:51 PDT (History)
3 users (show)

See Also:

Patch (11.01 KB, patch)
2012-04-10 10:12 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch (11.98 KB, patch)
2012-04-10 11:33 PDT, Jocelyn Turcotte
noam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-04-10 09:36:16 PDT
[Qt] Fix issues when using the WebView as ShaderEffectSource
Comment 1 Jocelyn Turcotte 2012-04-10 10:12:15 PDT
Created attachment 136480 [details]
Comment 2 Noam Rosenthal 2012-04-10 10:38:49 PDT
Comment on attachment 136480 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=136480&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:126
> +    virtual void beginPainting(bool mirrored = false) { }

Boolean trap. Let's make it an enum.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:500
> +static inline TransformationMatrix createProjectionMatrix(const IntSize& size, bool mirrored)

While we're at it, let's make this an enum (probably the same enum).
Comment 3 Jocelyn Turcotte 2012-04-10 11:33:40 PDT
Created attachment 136495 [details]

Using PaintingFlag instead of a mirrored bool.
It felt a bit stretched to use the generic flag in the createProjectionMatrix static method so I leaved it as before but used const bools for the mirrored parameter in callers.
Comment 4 Noam Rosenthal 2012-04-10 11:42:10 PDT
Comment on attachment 136495 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=136495&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:107
> +    enum PaintingFlag {
> +        PaintingMirrored = 1 << 0,

Comment 5 Jocelyn Turcotte 2012-04-11 07:51:06 PDT
Committed r113859: <http://trac.webkit.org/changeset/113859>