Bug 83572 – Height overflow when nesting multiple new Flexbox'es.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[simurai]

It appears that when nesting multiple "new" Flexbox'es, the total height of its flexible children are overflowing.

See: http://jsfiddle.net/simurai/BQW3Y/

Note: In the old Flexbox ( display: -webkit-box; ) it works fine.

[Tony Chang]

*** Bug 85490 has been marked as a duplicate of this bug. ***

[Tony Chang]

Created attachment 140094 [details]
Patch

[Ojan Vafai]

Comment on attachment 140094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140094&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:606
> +        return overrideContentLogicalHeight - preferredMainAxisExtent;

Now that all return cases subtract preferredMainAxisExtent, I wonder if we should rename this method computeMainAxisExtent and subtract preferredMainAxisExtent in the one calling location.

Up to you.

[Tony Chang]

Created attachment 140101 [details]
Patch for landing

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 140094 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140094&action=review
> 
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:606
> > +        return overrideContentLogicalHeight - preferredMainAxisExtent;
> 
> Now that all return cases subtract preferredMainAxisExtent, I wonder if we should rename this method computeMainAxisExtent and subtract preferredMainAxisExtent in the one calling location.

I did a variation that subtracts preferredMainAxisExtent at the end of the method.  It's convenient that the concept of available free space is a function.

[WebKit Review Bot]

Comment on attachment 140101 [details]
Patch for landing

Clearing flags on attachment: 140101

Committed r116038: <http://trac.webkit.org/changeset/116038>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.