Bug 83554 - DFG should flush SetLocals to arguments
Summary: DFG should flush SetLocals to arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-04-10 01:18 PDT by Filip Pizlo
Modified: 2012-04-10 17:37 PDT (History)
1 user (show)

See Also:

Attachments
the patch (7.33 KB, patch)
2012-04-10 01:23 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
the patch (31.28 KB, patch)
2012-04-10 15:27 PDT, Filip Pizlo 		buildbot: commit-queue-
Details | Formatted Diff | Diff
the patch (31.38 KB, patch)
2012-04-10 15:46 PDT, Filip Pizlo 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-04-10 01:18:53 PDT 
This is necessary to match baseline JIT argument capture behavior.
Comment 1 Filip Pizlo 2012-04-10 01:23:51 PDT 
Created attachment 136412 [details]
the patch
Comment 2 Geoffrey Garen 2012-04-10 08:30:10 PDT 
<rdar://problem/11215848>
Comment 3 Filip Pizlo 2012-04-10 15:27:28 PDT 
Created attachment 136557 [details]
the patch
Comment 4 Build Bot 2012-04-10 15:36:19 PDT 
Comment on attachment 136557 [details]
the patch

Attachment 136557 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12380546
Comment 5 Filip Pizlo 2012-04-10 15:46:38 PDT 
Created attachment 136559 [details]
the patch
Comment 6 Gavin Barraclough 2012-04-10 16:15:35 PDT 
Comment on attachment 136559 [details]
the patch

ArgumentPosition isn't a position, so I'd suggest a different name, but since I don't have a better one, R+ either way.
Comment 7 Filip Pizlo 2012-04-10 17:37:43 PDT 
Landed in http://trac.webkit.org/changeset/113796