RESOLVED FIXED 83547
Clean up CSSParser::parseFillRepeat(). 
https://bugs.webkit.org/show_bug.cgi?id=83547
Summary Clean up CSSParser::parseFillRepeat().
Luke Macpherson
Reported 2012-04-09 21:52:04 PDT
Clean up CSSParser::parseFillRepeat().
Attachments
Patch (2.90 KB, patch)
2012-04-09 21:54 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2012-04-10 16:14 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-04-09 21:54:30 PDT
Created attachment 136395 [details] Patch
Kentaro Hara
Comment 2 2012-04-10 03:10:51 PDT
Comment on attachment 136395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136395&action=review > Source/WebCore/css/CSSParser.cpp:3306 > + > + // If only one value was specified, value2 is the same as value1. > + m_implicitShorthand = true; > + value2 = cssValuePool().createIdentifierValue(static_cast<CSSPrimitiveValue*>(value1.get())->getIdent()); Shouldn't this code be inside the else block of 'if (id == CSSValueRepeat || ...) { .... } else { /* here! */ }'?
Luke Macpherson
Comment 3 2012-04-10 16:13:13 PDT
Comment on attachment 136395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136395&action=review >> Source/WebCore/css/CSSParser.cpp:3306 >> + value2 = cssValuePool().createIdentifierValue(static_cast<CSSPrimitiveValue*>(value1.get())->getIdent()); > > Shouldn't this code be inside the else block of 'if (id == CSSValueRepeat || ...) { .... } else { /* here! */ }'? You're basically right - I missed the early return statement there.
Luke Macpherson
Comment 4 2012-04-10 16:14:04 PDT
Created attachment 136566 [details] Patch
Kentaro Hara
Comment 5 2012-04-17 13:51:16 PDT
Comment on attachment 136566 [details] Patch Looks OK.
WebKit Review Bot
Comment 6 2012-04-17 15:17:12 PDT
Comment on attachment 136566 [details] Patch Clearing flags on attachment: 136566 Committed r114444: <http://trac.webkit.org/changeset/114444>
WebKit Review Bot
Comment 7 2012-04-17 15:17:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.