Bug 83547 - Clean up CSSParser::parseFillRepeat().
: Clean up CSSParser::parseFillRepeat().
Status: RESOLVED FIXED
: WebKit
CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-09 21:52 PST by
Modified: 2012-04-17 15:17 PST (History)


Attachments
Patch (2.90 KB, patch)
2012-04-09 21:54 PST, Luke Macpherson
no flags Review Patch | Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2012-04-10 16:14 PST, Luke Macpherson
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-09 21:52:04 PST
Clean up CSSParser::parseFillRepeat().
------- Comment #1 From 2012-04-09 21:54:30 PST -------
Created an attachment (id=136395) [details]
Patch
------- Comment #2 From 2012-04-10 03:10:51 PST -------
(From update of attachment 136395 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=136395&action=review

> Source/WebCore/css/CSSParser.cpp:3306
> +
> +    // If only one value was specified, value2 is the same as value1.
> +    m_implicitShorthand = true;
> +    value2 = cssValuePool().createIdentifierValue(static_cast<CSSPrimitiveValue*>(value1.get())->getIdent());

Shouldn't this code be inside the else block of 'if (id == CSSValueRepeat || ...) { .... } else { /* here! */ }'?
------- Comment #3 From 2012-04-10 16:13:13 PST -------
(From update of attachment 136395 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=136395&action=review

>> Source/WebCore/css/CSSParser.cpp:3306
>> +    value2 = cssValuePool().createIdentifierValue(static_cast<CSSPrimitiveValue*>(value1.get())->getIdent());
> 
> Shouldn't this code be inside the else block of 'if (id == CSSValueRepeat || ...) { .... } else { /* here! */ }'?

You're basically right - I missed the early return statement there.
------- Comment #4 From 2012-04-10 16:14:04 PST -------
Created an attachment (id=136566) [details]
Patch
------- Comment #5 From 2012-04-17 13:51:16 PST -------
(From update of attachment 136566 [details])
Looks OK.
------- Comment #6 From 2012-04-17 15:17:12 PST -------
(From update of attachment 136566 [details])
Clearing flags on attachment: 136566

Committed r114444: <http://trac.webkit.org/changeset/114444>
------- Comment #7 From 2012-04-17 15:17:21 PST -------
All reviewed patches have been landed.  Closing bug.