Bug 83534 - If a callback function returns a C++ null, convert to undefined.
Summary: If a callback function returns a C++ null, convert to undefined.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-09 18:38 PDT by Gavin Barraclough
Modified: 2012-04-09 18:41 PDT (History)
0 users

See Also:


Attachments
Fix (3.02 KB, patch)
2012-04-09 18:39 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2012-04-09 18:38:28 PDT
Previously we didn't check for NULL return values here, recently we hardened the API to throw an error, but this is too restrictive for some clients.  Instead just promote to a JS undefined.
Comment 1 Gavin Barraclough 2012-04-09 18:39:12 PDT
Created attachment 136364 [details]
Fix
Comment 2 Geoffrey Garen 2012-04-09 18:40:13 PDT
Comment on attachment 136364 [details]
Fix

r=me
Comment 3 Gavin Barraclough 2012-04-09 18:41:41 PDT
Fixed in r113654