Bug 83507 - Clean up LayoutUnit usage in DOMNodeHighlighter
Summary: Clean up LayoutUnit usage in DOMNodeHighlighter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-09 14:30 PDT by Levi Weintraub
Modified: 2012-04-09 19:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2012-04-09 14:39 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-09 14:30:27 PDT 
Bringing DOMNodeHighlighter in line with the subpixellayout branch.
Comment 1 Levi Weintraub 2012-04-09 14:39:56 PDT 
Created attachment 136309 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-09 14:41:48 PDT 
Comment on attachment 136309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136309&action=review

> Source/WebCore/ChangeLog:11
> +        Ensuring DOMNodeHighlighter uses pixel snapping that matches that done in the RenderTree. Changes include:
> +        - Reverting drawSubstring to use an IntPoint with pixel snapped values instead of a LayoutPoint.
> +        - Reverting borderBox to an IntRect since it's in absolute coordinates. See https://trac.webkit.org/wiki/LayoutUnit.
> +        - Frames are still laid out with integers. Cleaning up mainFrameOffset to reflect that.

Nicely stated!
Comment 3 Levi Weintraub 2012-04-09 14:43:48 PDT 
Comment on attachment 136309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136309&action=review

>> Source/WebCore/ChangeLog:11
>> +        - Frames are still laid out with integers. Cleaning up mainFrameOffset to reflect that.
> 
> Nicely stated!

Thanks!
Comment 4 WebKit Review Bot 2012-04-09 19:32:36 PDT 
Comment on attachment 136309 [details]
Patch

Clearing flags on attachment: 136309

Committed r113663: <http://trac.webkit.org/changeset/113663>
Comment 5 WebKit Review Bot 2012-04-09 19:32:41 PDT 
All reviewed patches have been landed.  Closing bug.