RESOLVED FIXED 83505
Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues 
https://bugs.webkit.org/show_bug.cgi?id=83505
Summary Remove setTimeout from media/video-seek-past-end-paused.html and fix other mi...
Victoria Kirst
Reported 2012-04-09 13:47:17 PDT
Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues
Attachments
Patch (6.41 KB, patch)
2012-04-09 13:54 PDT, Victoria Kirst 		no flags
DetailsFormatted DiffDiff
Patch (6.40 KB, patch)
2012-04-09 14:38 PDT, Victoria Kirst 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Victoria Kirst
Comment 1 2012-04-09 13:54:44 PDT
Created attachment 136302 [details] Patch
Eric Carlson
Comment 2 2012-04-09 14:27:28 PDT
Comment on attachment 136302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136302&action=review > LayoutTests/media/video-seek-past-end-paused.html:14 > + run("video.load()"); Nit: load() is unnecessary, setting 'src' implicitly schedules a load.
Victoria Kirst
Comment 3 2012-04-09 14:38:50 PDT
Created attachment 136308 [details] Patch
Victoria Kirst
Comment 4 2012-04-09 14:45:11 PDT
Comment on attachment 136308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136302&action=review >> LayoutTests/media/video-seek-past-end-paused.html:14 >> + run("video.load()"); > > Nit: load() is unnecessary, setting 'src' implicitly schedules a load. Thanks! Removed, and moved the line to set src waitForEvent('canplaythrough').
WebKit Review Bot
Comment 5 2012-04-09 18:55:56 PDT
Comment on attachment 136308 [details] Patch Rejecting attachment 136308 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12374325
Victoria Kirst
Comment 6 2012-04-12 11:25:37 PDT
Committed r114005: <http://trac.webkit.org/changeset/114005>
Note You need to log in before you can comment on or make changes to this bug.