Bug 83504 – [chromium] Replica layers are not drawn, so should not be painted

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Don't waste time trying to paint replica layers

[Dana Jansens]

We attempt to paint replica layers when we are painting the mask layers in CCLayerTreeHost.cpp.

This is useless code, replica layers have drawsContent() == false, and have an empty visibleLayerRect, so the paint functions end up early-outting. But it is a waste of time to try, and confusing to have this attempted in the code at all, since the replica layers are never drawn. They exist only for their transforms.

Also the dimensions used for the mask are different from the surface mask, which is confusing and unnecessary as well. The mask is applied to the same surface contents as the surface mask would be, so only the surface's contentBounds need to be painted in the replica mask.

[Dana Jansens]

Created attachment 136297 [details]
Patch

[James Robinson]

Comment on attachment 136297 [details]
Patch

Seems like paintMaskAndReplicaForRenderSurface() needs a rename, no?

[Dana Jansens]

Created attachment 136300 [details]
Patch

yes!

[James Robinson]

Comment on attachment 136300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136300&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:531
> +        LayerChromium* maskLayer = replicaLayer->maskLayer();

this shadows the earlier local which is a bit weird (and I wouldn't be surprised if triggered a warning on some pedantic compiler somewhere). Can you:
*) reuse the local
*) pick another name
*) refactor shared code into a helper so we don't have to duplicate this block?

[Dana Jansens]

done, renamed to replicaMaskLayer.

[Dana Jansens]

Created attachment 136313 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 136313 [details]
Patch for landing

Clearing flags on attachment: 136313

Committed r113668: <http://trac.webkit.org/changeset/113668>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.