Bug 83473 - [BlackBerry] Implement Web Inspector methods in LayoutTestController
Summary: [BlackBerry] Implement Web Inspector methods in LayoutTestController
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konrad Piascik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-09 08:33 PDT by Konrad Piascik
Modified: 2014-01-28 19:58 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.29 KB, patch)
2012-04-09 09:42 PDT, Konrad Piascik
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Piascik 2012-04-09 08:33:09 PDT
[BlackBerry] Implement Web Inspector methods in LayoutTestController
Comment 1 Konrad Piascik 2012-04-09 09:42:17 PDT
Created attachment 136242 [details]
Patch
Comment 2 Daniel Bates 2012-04-09 21:06:27 PDT
Comment on attachment 136242 [details]
Patch

This patch looks straightforward to me.

r=me.
Comment 3 Daniel Bates 2012-04-09 21:09:49 PDT
Comment on attachment 136242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136242&action=review

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:507
> +    WTF::String scriptStr = jsStringRefToWebCoreString(script);

Nit: I don't see the value of abbreviating the word "string" here. I suggest naming this variable scriptString.
Comment 4 Eric Seidel (no email) 2013-01-04 00:51:01 PST
Attachment 136242 [details] was posted by a committer and has review+, assigning to Konrad Piascik for commit.
Comment 5 Konrad Piascik 2013-01-04 10:18:42 PST
Comment on attachment 136242 [details]
Patch

This change doesn't do anything and is simply a setup for future work to get inspector tests to work.  I'll upload another patch which will have this work with other changes later rather than splitting it into two separate commits.
Comment 6 Eric Seidel (no email) 2013-03-01 10:36:57 PST
Comment on attachment 136242 [details]
Patch

Cleared Daniel Bates's review+ from obsolete attachment 136242 [details] so that this bug does not appear in http://webkit.org/pending-commit.