Bug 83437 – Command-line jsc's exception handling should be rationalized

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Currently it will swallow and ignore exceptions thrown during a run() execution.  If a program terminates because of an exception, the exception is not printed by default.  It is only printed if we enable bytecode dumping.  It should be enabled always.  The backtrace is never printed even though we almost always have one.

[Filip Pizlo]

Created attachment 136156 [details]
the patch

Comment on attachment 136156 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136156&action=review

> Source/JavaScriptCore/jsc.cpp:532
>          if (dump) {
> -            if (evaluationException)
> -                printf("Exception: %s\n", evaluationException.toString(globalObject->globalExec())->value(globalObject->globalExec()).utf8().data());
> -            else
> +            if (!evaluationException)

Now that there’s no else clause inside you can just write
    if (dump && !evaluationException)

[Filip Pizlo]

(In reply to comment #2)
> (From update of attachment 136156 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136156&action=review
> 
> > Source/JavaScriptCore/jsc.cpp:532
> >          if (dump) {
> > -            if (evaluationException)
> > -                printf("Exception: %s\n", evaluationException.toString(globalObject->globalExec())->value(globalObject->globalExec()).utf8().data());
> > -            else
> > +            if (!evaluationException)
> 
> Now that there’s no else clause inside you can just write
>     if (dump && !evaluationException)

Good point, thanks for the review!

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/113553