Bug 83436 – [WIN] Use GetDateFormat and GetTimeFormat instead of strftime

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

[WIN] Use GetDateFormat and GetTimeFormat instead of strftime

[Patrick R. Gansterer]

Created attachment 136154 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 136154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136154&action=review

> Source/JavaScriptCore/runtime/DatePrototype.cpp:233
> +    UChar buffer[128];

How do we know this is long enough? Maybe we should use something like Vector<UChar, 128> and grow it if it turns out to be too small.

[Patrick R. Gansterer]

Created attachment 144922 [details]
Patch

[Brent Fulgham]

Comment on attachment 144922 [details]
Patch

Looks good to me!

[Patrick R. Gansterer]

Committed r123293: <http://trac.webkit.org/changeset/123293>

FYI:

GetTimeFormat works only for year 1601 to 320827.
http://msdn.microsoft.com/en-us/library/windows/desktop/ms724950(v=vs.85).aspx

It doesn't cover full JavaScript Date range.
https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date/

GetTimeFormat also doesn't work with HTML5 Date range. So, we implemented formatDate for Windows in WebCore.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/text/LocaleWin.cpp

[Patrick R. Gansterer]

(In reply to comment #6)
> GetTimeFormat works only for year 1601 to 320827.
> http://msdn.microsoft.com/en-us/library/windows/desktop/ms724950(v=vs.85).aspx

Yes, but the current call to strftime() does not even return correct values for dates before 1900 on my windows 7 machine with VS2010.