Bug 83409 - bindAttribLocation should check webgl reserved prefix
Summary: bindAttribLocation should check webgl reserved prefix
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhenyao Mo
Depends on:
Reported: 2012-04-06 16:24 PDT by Zhenyao Mo
Modified: 2012-04-09 15:40 PDT (History)
1 user (show)

See Also:

Patch (5.72 KB, patch)
2012-04-06 17:19 PDT, Zhenyao Mo
no flags Details | Formatted Diff | Diff
Patch (5.74 KB, patch)
2012-04-09 12:32 PDT, Zhenyao Mo
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2012-04-06 16:24:53 PDT
right now it just passes down to command buffer, where command buffer only checks for "gl_".
Comment 1 Zhenyao Mo 2012-04-06 17:19:45 PDT
Created attachment 136106 [details]
Comment 2 Zhenyao Mo 2012-04-06 17:21:11 PDT
Ken, please review.
Comment 3 Kenneth Russell 2012-04-09 11:41:25 PDT
Comment on attachment 136106 [details]

Looks good. Can you make sure these changes make it into the WebGL conformance suite (and email public_webgl about their addition)? Thanks.
Comment 4 Zhenyao Mo 2012-04-09 12:32:47 PDT
Created attachment 136285 [details]
Comment 5 Zhenyao Mo 2012-04-09 12:37:43 PDT
The changes are already in the khronos and then I synced to layout tests.  I'll email it to the public_webgl.
Comment 6 Zhenyao Mo 2012-04-09 12:45:21 PDT
by the way, the second patch is the same as the first one.  I simply did an webkit-update and reuploaded.  You don't have to look again.
Comment 7 Kenneth Russell 2012-04-09 15:08:57 PDT
Comment on attachment 136285 [details]

Still looks fine.
Comment 8 Zhenyao Mo 2012-04-09 15:40:46 PDT
Committed r113634: <http://trac.webkit.org/changeset/113634>