Bug 83407 - [chromium] Clear values in combinedClear path not respected in WebGLRenderingContext::clearIfComposited()
Summary: [chromium] Clear values in combinedClear path not respected in WebGLRendering...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-06 15:50 PDT by James Robinson
Modified: 2012-04-06 16:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.96 KB, patch)
2012-04-06 15:51 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (9.33 KB, patch)
2012-04-06 15:58 PDT, James Robinson 		kbr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-04-06 15:50:39 PDT 
[chromium] Clear values in combinedClear path not respected in WebGLRenderingContext::clearIfComposited()
Comment 1 James Robinson 2012-04-06 15:51:21 PDT 
Created attachment 136081 [details]
Patch
Comment 2 James Robinson 2012-04-06 15:52:01 PDT 
This fixes the regressions in http://code.google.com/p/chromium/issues/detail?id=122463.  I need to add some layout test coverage before landing (which is why I left the OOPS! in), but posting the code first so folks can look at it.
Comment 3 James Robinson 2012-04-06 15:58:37 PDT 
Created attachment 136083 [details]
Patch
Comment 4 James Robinson 2012-04-06 16:00:10 PDT 
Turns out fast/canvas/webgl/canvas-test.html covers this when run interactively, but since it was running in DRT without any explicit display() calls we didn't hit the same clearIfComposited() calls and the bug didn't manifest.  Tweaked the test to do something closer to what a real browser does so it would catch this regression.
Comment 5 Kenneth Russell 2012-04-06 16:05:00 PDT 
Comment on attachment 136083 [details]
Patch

LGTM as long as it's been tested.
Comment 6 James Robinson 2012-04-06 16:08:53 PDT 
Thanks. I've checked this on the layout tests, the failure gpu_tests test, and manually made sure the webgl aquarium shows up so I think we're good.  Of course, I thought that last time too so my record isn't that great :)
Comment 7 James Robinson 2012-04-06 16:09:52 PDT 
Committed r113517: <http://trac.webkit.org/changeset/113517>