Bug 83383 - [chromium] Add more layout tests a videos that changes dimensions while decoding
Summary: [chromium] Add more layout tests a videos that changes dimensions while decoding
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Scherkus
Depends on:
Reported: 2012-04-06 12:02 PDT by Andrew Scherkus
Modified: 2012-04-07 20:47 PDT (History)
3 users (show)

See Also:

Patch (4.55 KB, patch)
2012-04-06 12:03 PDT, Andrew Scherkus
no flags Details | Formatted Diff | Diff
Patch (9.01 KB, patch)
2012-04-06 18:01 PDT, Andrew Scherkus
jamesr: review+
jamesr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2012-04-06 12:02:15 PDT
Need tests for both the software rendering path _and_ the compositing path!
Comment 1 Andrew Scherkus 2012-04-06 12:03:13 PDT
Created attachment 136047 [details]
Comment 2 James Robinson 2012-04-06 14:45:47 PDT
This doesn't seem to update any expectations - is the idea that we just want to run through the presentation paths, but we don't really want to check what happens (just that we don't crash)?
Comment 3 Andrew Scherkus 2012-04-06 14:56:54 PDT
the compositing/ test does a pixel test and verifies that we're doing the right thing (rendering + scaling decoded video that has differing dimensions from frame zero)

the media/ test verifies the DOM-level changes but ideally should also have a pixel test associated with it -- let me update that one
Comment 4 Andrew Scherkus 2012-04-06 18:01:51 PDT
Created attachment 136111 [details]
Comment 5 Andrew Scherkus 2012-04-06 18:02:05 PDT
Comment 6 James Robinson 2012-04-06 18:05:39 PDT
Comment on attachment 136111 [details]

Looks good but where da PNGs at?
Comment 7 Andrew Scherkus 2012-04-06 18:07:36 PDT
I'll fix up test_expectations.txt and grab them off the bots
Comment 8 Andrew Scherkus 2012-04-06 19:17:49 PDT
patch landed as http://trac.webkit.org/changeset/113536

waiting for baselines to be generated
Comment 9 Andrew Scherkus 2012-04-07 20:47:51 PDT
baselines added in baselines added in http://trac.webkit.org/changeset/113550