Bug 83370 - [chromium] Scratch texture reused before SkBitmap releases ownership
Summary: [chromium] Scratch texture reused before SkBitmap releases ownership
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-06 07:56 PDT by Dana Jansens
Modified: 2012-07-20 14:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.79 KB, patch)
2012-04-06 07:56 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (3.55 KB, patch)
2012-07-20 13:02 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch for landing (3.60 KB, patch)
2012-07-20 13:39 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-04-06 07:56:14 PDT 
[chromium] Scratch texture reused before SkBitmap releases ownership
Comment 1 Dana Jansens 2012-04-06 07:56:35 PDT 
Created attachment 136023 [details]
Patch

This is a repro for the scratch texture bug.
Comment 2 Stephen White 2012-07-20 13:02:25 PDT 
Created attachment 153576 [details]
Patch
Comment 3 Adrienne Walker 2012-07-20 13:29:37 PDT 
Comment on attachment 153576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153576&action=review

R=me.  Wow, GrAutoScratchTexture is way better than manual locking and unlocking.

> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:207
> +        GrAutoScratchTexture ast(gr, desc, GrContext::kExact_ScratchTexMatch);
> +        SkAutoTUnref<GrTexture> dest(ast.detach());

style nit: Argh, abbreviations.
Comment 4 Stephen White 2012-07-20 13:39:41 PDT 
Created attachment 153587 [details]
Patch for landing
Comment 5 Stephen White 2012-07-20 13:59:49 PDT 
Thanks for the review.  I've un-abbreviated the variables on landing.
Comment 6 WebKit Review Bot 2012-07-20 14:24:21 PDT 
Comment on attachment 153587 [details]
Patch for landing

Clearing flags on attachment: 153587

Committed r123260: <http://trac.webkit.org/changeset/123260>
Comment 7 WebKit Review Bot 2012-07-20 14:24:24 PDT 
All reviewed patches have been landed.  Closing bug.