WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 83365
Web Inspector: display frame details in popover on frame strip in Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=83365
Summary
Web Inspector: display frame details in popover on frame strip in Timeline panel
Andrey Kosyakov
Reported
2012-04-06 07:07:41 PDT
Add a popover with frame details on hover upon frame strip in the Timeline panel.
Attachments
Patch
(12.46 KB, patch)
2012-04-06 07:16 PDT
,
Andrey Kosyakov
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1
2012-04-06 07:16:27 PDT
Created
attachment 136019
[details]
Patch
Pavel Feldman
Comment 2
2012-04-06 07:26:24 PDT
Comment on
attachment 136019
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=136019&action=review
> Source/WebCore/inspector/front-end/TimelinePanel.js:372 > + frameStrip.__frame = frame;
Since you own this element, there is no point to use __ for the naming.
> Source/WebCore/inspector/front-end/TimelinePanel.js:758 > + if (anchor.classList.contains("timeline-frame-strip")) {
Please use hasStyleClass for consistency.
Andrey Kosyakov
Comment 3
2012-04-06 07:44:46 PDT
Committed
r113434
: <
http://trac.webkit.org/changeset/113434
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug