Bug 83365 - Web Inspector: display frame details in popover on frame strip in Timeline panel
Summary: Web Inspector: display frame details in popover on frame strip in Timeline panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-06 07:07 PDT by Andrey Kosyakov
Modified: 2012-04-06 07:44 PDT (History)
10 users (show)

See Also:

Attachments
Patch (12.46 KB, patch)
2012-04-06 07:16 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-04-06 07:07:41 PDT 
Add a popover with frame details on hover upon frame strip in the Timeline panel.
Comment 1 Andrey Kosyakov 2012-04-06 07:16:27 PDT 
Created attachment 136019 [details]
Patch
Comment 2 Pavel Feldman 2012-04-06 07:26:24 PDT 
Comment on attachment 136019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136019&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:372
> +            frameStrip.__frame = frame;

Since you own this element, there is no point to use __ for the naming.

> Source/WebCore/inspector/front-end/TimelinePanel.js:758
> +        if (anchor.classList.contains("timeline-frame-strip")) {

Please use hasStyleClass for consistency.
Comment 3 Andrey Kosyakov 2012-04-06 07:44:46 PDT 
Committed r113434: <http://trac.webkit.org/changeset/113434>