Bug 83361 - [BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
Summary: [BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-06 04:47 PDT by Charles Wei
Modified: 2012-04-11 13:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2012-04-06 04:52 PDT, Charles Wei 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2012-04-11 13:06 PDT, Rob Buis 		tonikitoo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-04-06 04:47:51 PDT 
BlackBerry porting uses the same PatternSkia.cpp,  but doesn't want the v8 specific code.
Comment 1 Charles Wei 2012-04-06 04:52:01 PDT 
Created attachment 136003 [details]
Patch
Comment 2 Rob Buis 2012-04-06 05:43:40 PDT 
Comment on attachment 136003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136003&action=review

One mistake found. Also is Filip not working on this? Or did he touch this file already?

> Source/WebCore/platform/graphics/skia/PatternSkia.cpp:52
>      m_pattern = 0;

This seems wrong.
Comment 3 Rob Buis 2012-04-11 08:10:24 PDT 
Comment on attachment 136003 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136003&action=review

>> Source/WebCore/platform/graphics/skia/PatternSkia.cpp:52
>>      m_pattern = 0;
> 
> This seems wrong.

To be clear, it seems like we still want to delete m_pattern? I can imagine we do not want V8 code of course.
Comment 4 Rob Buis 2012-04-11 13:06:14 PDT 
Created attachment 136733 [details]
Patch
Comment 5 Rob Buis 2012-04-11 13:25:59 PDT 
Landed in r113903.