Bug 83343 - Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
Summary: Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-05 18:41 PDT by Emil A Eklund
Modified: 2012-06-25 05:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.52 KB, patch)
2012-04-05 18:44 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-04-05 18:41:53 PDT 
Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
Comment 1 Emil A Eklund 2012-04-05 18:44:38 PDT 
Created attachment 135963 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-06 11:56:16 PDT 
Comment on attachment 135963 [details]
Patch

Clearing flags on attachment: 135963

Committed r113471: <http://trac.webkit.org/changeset/113471>
Comment 3 WebKit Review Bot 2012-04-06 11:56:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Allan Sandfeld Jensen 2012-06-25 05:16:36 PDT 
Comment on attachment 135963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135963&action=review

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:267
> +    IntPoint roundedPoint = roundedIntPoint(pointInContainer);
>  
>      if (Scrollbar* horizontalScrollbar = view->horizontalScrollbar()) {
> -        if (horizontalScrollbar->shouldParticipateInHitTesting() && horizontalScrollbar->frameRect().contains(pointInContainer)) {
> +        if (horizontalScrollbar->shouldParticipateInHitTesting() && horizontalScrollbar->frameRect().contains(roundedPoint)) {

I am curious, why is this rounding necessary?